undeclared variables

phpmyadmin · Nov 18, 2005 · a0b5695 · a0b5695
1 parent 3115a8d
commit a0b5695
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -23,7 +23,8 @@ $Source$
     * fixed minimum_common for css files
     * header.inc.php: missing ; after &quot
     * libraries/function.js::pdfPaperSize()
-      - javascript warning: function does not always return a vlaue
+      - function does not always return a vlaue
+      - undeclared variables
 
 2005-11-17 Marc Delisle  <lem9@users.sourceforge.net>
     * Documentation.html: patch #1353283, thanks to Isaac Bennetch

diff --git a/libraries/functions.js b/libraries/functions.js
@@ -357,11 +357,12 @@ function checkTableEditForm(theForm, fieldsCnt)
     // on the form but has not completed at least one field name
 
     var atLeastOneField = 0;
+    var i, elm, elm2, elm3, val, id;
 
     for (i=0; i<fieldsCnt; i++)
     {
-        var id = "field_" + i + "_2";
-        var elm = getElement(id);
+        id = "field_" + i + "_2";
+        elm = getElement(id);
         if (elm.value == 'VARCHAR' || elm.value == 'CHAR') {
             elm2 = getElement("field_" + i + "_3");
             val = parseInt(elm2.value);
@@ -375,7 +376,7 @@ function checkTableEditForm(theForm, fieldsCnt)
         }
 
         if (atLeastOneField == 0) {
-            var id = "field_" + i + "_1";
+            id = "field_" + i + "_1";
             if (!emptyCheckTheField(theForm, id)) {
                 atLeastOneField = 1;
             }