Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make the SQL exports compatible for side by side comparison with old …
…exports Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
- Loading branch information
Showing
4 changed files
with
5 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello,
This change is going to make all data types be built as lowercase. Is this the way you wanted it to be?
As far as I can know, only the data types in
CREATE TABLE
should be in lower case. For example, inCREATE FUNCTION
orCREATE PROCEDURE
the parameter or return type is upper case (this is whatSHOW CREATE PROCEDURE
orSHOW CREATE FUNCTION
produces).I redid all these changes in phpmyadmin/sql-parser@1b2988f, with the exception of this one. I did so lower case data types are built only when used to generate
CREATE TABLE
. Is that fine? If yes, I will submit a pull request with the new changes.