Skip to content

Commit b2f1e89

Browse files
author
Marc Delisle
committed
[security] Risk of BREACH attack
Thanks to Michal Čihař for the message suggestion. Signed-off-by: Marc Delisle <marc@infomarc.info>
1 parent 631ba4c commit b2f1e89

File tree

1 file changed

+4
-24
lines changed

1 file changed

+4
-24
lines changed

Diff for: libraries/select_lang.lib.php

+4-24
Original file line numberDiff line numberDiff line change
@@ -600,34 +600,14 @@ function PMA_langList()
600600

601601

602602
// now, that we have loaded the language strings we can send the errors
603-
if ($GLOBALS['lang_failed_cfg']) {
603+
if ($GLOBALS['lang_failed_cfg']
604+
|| $GLOBALS['lang_failed_cookie']
605+
|| $GLOBALS['lang_failed_request']) {
604606
trigger_error(
605-
sprintf(
606-
__('Unknown language: %1$s.'),
607-
htmlspecialchars($GLOBALS['lang_failed_cfg'])
608-
),
607+
__('Ignoring unsupported language code.'),
609608
E_USER_ERROR
610609
);
611610
}
612-
if ($GLOBALS['lang_failed_cookie']) {
613-
trigger_error(
614-
sprintf(
615-
__('Unknown language: %1$s.'),
616-
htmlspecialchars($GLOBALS['lang_failed_cookie'])
617-
),
618-
E_USER_ERROR
619-
);
620-
}
621-
if ($GLOBALS['lang_failed_request']) {
622-
trigger_error(
623-
sprintf(
624-
__('Unknown language: %1$s.'),
625-
htmlspecialchars($GLOBALS['lang_failed_request'])
626-
),
627-
E_USER_ERROR
628-
);
629-
}
630-
631611
unset(
632612
$line, $fall_back_lang, $GLOBALS['lang_failed_cfg'],
633613
$GLOBALS['lang_failed_cookie'], $GLOBALS['lang_failed_request']

0 commit comments

Comments
 (0)