Add tests for #16837

Signed-off-by: William Desportes <williamdes@wdes.fr>
phpmyadmin · Apr 19, 2021 · bfb40ce · bfb40ce
1 parent 2b8468c
commit bfb40ce
Showing 1 changed file with 29 additions and 7 deletions.
diff --git a/test/classes/TrackerTest.php b/test/classes/TrackerTest.php
@@ -676,20 +676,20 @@ public function getTrackedDataProvider(): array
     /**
      * Test for Tracker::parseQuery
      *
-     * @param string $query                  Query to parse
-     * @param string $type                   Expected type
-     * @param string $identifier             Expected identifier
-     * @param string $tablename              Expected tablename
-     * @param string $db                     Expected dbname
-     * @param string $tablename_after_rename Expected name after rename
+     * @param string      $query                  Query to parse
+     * @param string      $type                   Expected type
+     * @param string      $identifier             Expected identifier
+     * @param string|null $tablename              Expected tablename
+     * @param string|null $db                     Expected dbname
+     * @param string|null $tablename_after_rename Expected name after rename
      *
      * @dataProvider parseQueryData
      */
     public function testParseQuery(
         string $query,
         string $type,
         string $identifier,
-        string $tablename,
+        ?string $tablename,
         ?string $db = null,
         ?string $tablename_after_rename = null
     ): void {
@@ -734,6 +734,12 @@ public function testParseQuery(
      */
     public function parseQueryData(): array
     {
+        // query
+        // type
+        // identifier
+        // table name
+        // db (optional)
+        // table name after rename (optional)
         $query = [];
         /** TODO: Should test fail when USE is in conjunction with * identifiers?
         $query[] = array(
@@ -868,6 +874,22 @@ public function parseQueryData(): array
             'TRUNCATE',
             't1',
         ];
+        $query[] = [
+            'create table event(' . "\n"
+            . 'eventID varchar(10) not null,' . "\n"
+            . 'b char(30),' . "\n"
+            . 'c varchar(20),' . "\n"
+            . 'd TIME,' . "\n"
+            . 'e Date,' . "\n"
+            . 'f int,' . "\n"
+            . 'g char(70),' . "\n"
+            . 'h char(90),' . "\n"
+            . 'primary key(eventID)' . "\n"
+            . ')' . "\n",
+            'DDL',
+            'CREATE TABLE',
+            null,// switch this to 'event' when sql-parse is fixed
+        ];
 
         return $query;
     }