From 7d266456af35042f052c3f5403d416e6237dfd31 Mon Sep 17 00:00:00 2001 From: "J.M" Date: Sat, 30 Jun 2012 17:54:49 +0200 Subject: [PATCH 1/3] Fix undefined variable data in libraries/insert_edit.lib.php#1013 by adding parameter to function PMA_getPmaTypeSet --- libraries/insert_edit.lib.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libraries/insert_edit.lib.php b/libraries/insert_edit.lib.php index e44a1ee19d18..98937931d42b 100644 --- a/libraries/insert_edit.lib.php +++ b/libraries/insert_edit.lib.php @@ -675,7 +675,7 @@ function PMA_getValueColumn($column, $backup_field, $column_name_appendix, $html_output .= PMA_getPmaTypeSet( $column, $extracted_columnspec, $backup_field, $column_name_appendix, $unnullify_trigger, $tabindex, - $tabindex_for_value, $idindex + $tabindex_for_value, $idindex, $data ); } elseif ($column['is_binary'] || $column['is_blob']) { @@ -999,13 +999,14 @@ function PMA_getRadioButtonDependingOnLength( * @param integer $tabindex tab index * @param integer $tabindex_for_value offset for the values tabindex * @param integer $idindex id index + * @param array $data description of the column field * * @return string an html snippet */ function PMA_getPmaTypeSet( $column, $extracted_columnspec, $backup_field, $column_name_appendix, $unnullify_trigger, $tabindex, - $tabindex_for_value, $idindex + $tabindex_for_value, $idindex, $data ) { list($column_set_values, $select_size) = PMA_getColumnSetValueAndSelectSize( $column, $extracted_columnspec From c7e8afd0dcff47ed3c9b572f6f237a26fa435dc5 Mon Sep 17 00:00:00 2001 From: "J.M" Date: Sat, 30 Jun 2012 18:09:12 +0200 Subject: [PATCH 2/3] + rfe #3528994 [interface] Allow wrapping possibly long values in replication-status table --- ChangeLog | 1 + libraries/replication_gui.lib.php | 12 +++++++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index c226dd6ec90a..671283f4f7ae 100644 --- a/ChangeLog +++ b/ChangeLog @@ -42,6 +42,7 @@ VerboseMultiSubmit, ReplaceHelpImg + [import] New plugin: import mediawiki + Add Ajax support to Fast filter in order to search the term in all database tables - bug #3535015 [navi] DbFilter, TableFilter clear button hidden on Chrome ++ rfe #3528994 [interface] Allow wrapping possibly long values in replication-status table 3.5.3.0 (not yet released) diff --git a/libraries/replication_gui.lib.php b/libraries/replication_gui.lib.php index ca8ed5059ff7..58317e57701c 100644 --- a/libraries/replication_gui.lib.php +++ b/libraries/replication_gui.lib.php @@ -143,7 +143,17 @@ function PMA_replication_print_status_table($type, $hidden = false, $title = tru } else { echo ''; } - echo ${"server_{$type}_replication"}[0][$variable]; + // allow wrapping long table lists into multiple lines + static $variables_wrap = array( + 'Replicate_Do_DB', 'Replicate_Ignore_DB', + 'Replicate_Do_Table', 'Replicate_Ignore_Table', + 'Replicate_Wild_Do_Table', 'Replicate_Wild_Ignore_Table'); + if (in_array($variable, $variables_wrap)) { + echo str_replace(',', ', ', ${"server_{$type}_replication"}[0][$variable]); + } + else { + echo ${"server_{$type}_replication"}[0][$variable]; + } echo ''; echo ' '; From 2c6f80aa47fe8bc960f1e781e1197d97e30e5179 Mon Sep 17 00:00:00 2001 From: Marc Delisle Date: Sat, 30 Jun 2012 15:00:15 -0400 Subject: [PATCH 3/3] Bug #3539142 Normal INSERT does not show the statement --- tbl_replace.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tbl_replace.php b/tbl_replace.php index cc500c079f33..27dc249a7e29 100644 --- a/tbl_replace.php +++ b/tbl_replace.php @@ -371,7 +371,7 @@ exit; } -if (isset($return_to_sql_query)) { +if (! empty($return_to_sql_query)) { $disp_query = $GLOBALS['sql_query']; $disp_message = $message; unset($message);