Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After deleting all rows on a page, it returns to a blank page #10514

Closed
pma-import opened this issue Oct 14, 2013 · 9 comments
Closed

After deleting all rows on a page, it returns to a blank page #10514

pma-import opened this issue Oct 14, 2013 · 9 comments
Labels
Bug A problem or regression with an existing feature
Milestone

Comments

@pma-import
Copy link

To reproduce:

  1. Have a table that spans several pages in Browse mode.
  2. Go to the last page.
  3. Click "Check all" then delete those rows.

It then goes to a blank table. At the top it says "Your SQL query has been executed successfully" with the delete query below.
Then below that it says "Showing rows 720 - 719 (720 total, Query took 0.0014 sec)"
Then the query box - SELECT * FROMtableLIMIT 720 , 30 (the table now had 720 rows after deletion).
Then the table headers but no rows of the table.

I would expect it to either go to the previous page (which is now the last page of the table), or maybe the first page. At least it should show some data.


@pma-import
Copy link
Author

In my opinion, after deleting the rows, using the Check all, it should go to the previous page. This makes sense according to me.

I am working on it and will probably send a pull request when done.

What do others have to say about this?


  • Original author: abhikandoi2000

@pma-import
Copy link
Author

Abhiskek,
I agree with your suggestion.


  • Original author: lem9

@pma-import
Copy link
Author

Abhishek,
any progress on this?


  • Original author: lem9

@pma-import
Copy link
Author

Hi,

I sent a pull request to fix this bug ( #740 ).

What does the fix?
After deleting row(s) with multi actions submit, I compare the number of rows of the displayed table and the position of the first line to display. If number of rows <= position, position is updated.

I know that this fix added an error in PHPUnit test. I had to include another file in the test class, but in this file and another one, there are 2 functions (that I didn't create) with the same name.
Possibilities:

  • Rename one of them;
  • Factorize them;
  • Don't test (not a good way).

I just didn't want to do a bug fix and update the functions in the same pull request.

Hugues.


  • Original author: tithugues

@pma-import
Copy link
Author

  • assigned_to: Marc Delisle

  • Original author: lem9

@pma-import
Copy link
Author

  • summary: After deleting all rows on a page, it returns to a blank page. --> (ok 4.1.0-beta3) After deleting all rows on a page, it returns to a blank page
  • status: open --> resolved
  • Priority: 5 --> 1

  • Original author: lem9

@pma-import
Copy link
Author

Oh. Sorry Marc that I couldn't reply.
I tried fixing this bug, but got caught up due to my end-term exams.
But I am glad that it is fixed now.


  • Original author: abhikandoi2000

@pma-import
Copy link
Author

  • summary: (ok 4.1.0-beta3) After deleting all rows on a page, it returns to a blank page --> (ok 4.1.0-rc1) After deleting all rows on a page, it returns to a blank page

  • Original author: lem9

@pma-import
Copy link
Author

  • Status: resolved --> fixed

  • Original author: lem9

@pma-import pma-import added the Bug A problem or regression with an existing feature label Jul 24, 2015
@pma-import pma-import added this to the 4.1.0 milestone Jul 24, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants