Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Results not displayed if query ends in delimiter and comment #11339

Closed
udan11 opened this issue Aug 1, 2015 · 2 comments · Fixed by #11375
Closed

Results not displayed if query ends in delimiter and comment #11339

udan11 opened this issue Aug 1, 2015 · 2 comments · Fixed by #11375
Assignees
@lem9
Labels
Bug A problem or regression with an existing feature

Comments

@udan11
Copy link
Contributor

udan11 commented Aug 1, 2015

Hello,

When executing queries like the one below the results are not being displayed.

SELECT * FROM actor; -- test

It looks like removing ; from the query fixes this issue. This bug is in 4.4 too.
@nisargjhaveri nisargjhaveri mentioned this issue Aug 2, 2015
Merged
@lem9 lem9 closed this as completed Aug 2, 2015
@madhuracj madhuracj added the Bug A problem or regression with an existing feature label Aug 6, 2015
@lem9 lem9 reopened this Aug 8, 2015
@lem9
Copy link
Contributor

lem9 commented Aug 8, 2015

Due to #11368

nisargjhaveri referenced this issue Aug 8, 2015
@nisargjhaveri
Handle comments in the beginning of the query
55a2d06 
Signed-off-by: Nisarg Jhaveri <nisargjhaveri@gmail.com>
@nisargjhaveri
Copy link
Contributor

Some more example where the results are not displayed and which are probably related.

SELECT 1; /*comment*/SELECT 1;
SELECT 1; -- comment
SELECT 1;

@udan11 udan11 mentioned this issue Aug 9, 2015
Merged
@lem9 lem9 self-assigned this Aug 10, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lem9 lem9

Labels
Bug A problem or regression with an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrote a part of the import mechanism.
4 participants
@lem9 @madhuracj @udan11 @nisargjhaveri