New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up common.inc.php #11731

Closed
nijel opened this Issue Dec 8, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@nijel
Member

nijel commented Dec 8, 2015

Currently common.inc.php contains quite a lot of if cases for "minimal" inclusion. It should be split into two separate files, one doing the "minimal" set of things and second one the others on top of it. This way we can get rid of the PMA_MINIMUM_COMMON define and make the code cleaner.

@nijel nijel added the refactoring label Dec 8, 2015

@nijel nijel self-assigned this Dec 9, 2015

@nijel nijel added this to the 4.6.0 milestone Dec 9, 2015

nijel added a commit that referenced this issue Dec 9, 2015

Move PATH_INFO cleanup to function
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Dec 9, 2015

Move PHP extensions check to separate function
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Dec 9, 2015

Move theme initialization to ThemeManager
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

@nijel nijel modified the milestones: 4.7.0, 4.6.0 Feb 4, 2016

@wadhwasahil

This comment has been minimized.

Show comment
Hide comment
@wadhwasahil

wadhwasahil Feb 19, 2016

Can I take up this issue?

wadhwasahil commented Feb 19, 2016

Can I take up this issue?

@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Feb 19, 2016

Member

As you can see it's assigned ;-). Anyway I'm slowly progressing with this (slowly mostly due to doing lot of other cleanups on the way).

Member

nijel commented Feb 19, 2016

As you can see it's assigned ;-). Anyway I'm slowly progressing with this (slowly mostly due to doing lot of other cleanups on the way).

@wadhwasahil

This comment has been minimized.

Show comment
Hide comment
@wadhwasahil

wadhwasahil Feb 19, 2016

So, can I collaborate?

wadhwasahil commented Feb 19, 2016

So, can I collaborate?

@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Feb 19, 2016

Member

You can work on some tasks which will make this easier, eg. #11988 or #11989.

Member

nijel commented Feb 19, 2016

You can work on some tasks which will make this easier, eg. #11988 or #11989.

nijel added a commit that referenced this issue Mar 8, 2016

Move logging helpers to class
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Mar 8, 2016

Move charset conversion to a class
Also removes ancient support for AIX iconv.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Mar 8, 2016

Move Kanji encoding handling to Encoding class
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Apr 11, 2016

Remove unused variable mysql_collations_flat
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Apr 11, 2016

Move MySQL charset maps to separate class
This allows us to load it only when needed

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Apr 11, 2016

Move MySQL charsets handling to the Charsets class
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Dec 7, 2016

Remove is_ajax_request global
We already have the same information on Response object, so let's use it
from there.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

@nijel nijel removed this from the 4.7.0 milestone Jan 7, 2017

nijel added a commit that referenced this issue Sep 4, 2017

Move PHP confguration to Core class
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Sep 4, 2017

Move configuration checks to Core
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit to nijel/phpmyadmin that referenced this issue Sep 5, 2017

Refactor congfiguration descriptions into class
This avoids loading them all into global namespace on every request.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit to nijel/phpmyadmin that referenced this issue Sep 5, 2017

Refactor congfiguration descriptions into class
This avoids loading them all into global namespace on every request.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit to nijel/phpmyadmin that referenced this issue Sep 5, 2017

Refactor congfiguration descriptions into class
This avoids loading them all into global namespace on every request.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit to nijel/phpmyadmin that referenced this issue Sep 5, 2017

Refactor configuration descriptions into class
This avoids loading them all into global namespace on every request.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Sep 5, 2017

Refactor configuration descriptions into class
This avoids loading them all into global namespace on every request.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit to nijel/phpmyadmin that referenced this issue Sep 6, 2017

Remove no longer needed page_settings.forms.php and user_preferences.…
…forms.php

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit to nijel/phpmyadmin that referenced this issue Oct 3, 2017

Move server selection to Config class
- move server selection from common.inc.php to Config class
- add tests covering most usual cases

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

@nijel nijel referenced this issue Oct 3, 2017

Merged

Move server selection to Config class #13718

4 of 4 tasks complete

nijel added a commit to nijel/phpmyadmin that referenced this issue Oct 3, 2017

Move server selection to Config class
- move server selection from common.inc.php to Config class
- add tests covering most usual cases

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit to nijel/phpmyadmin that referenced this issue Oct 3, 2017

Move server selection to Config class
- move server selection from common.inc.php to Config class
- add tests covering most usual cases

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Oct 10, 2017

Bind Types to DatabaseInterface
This wayt it's automatically passed with DBI.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Oct 10, 2017

Load SQL parser context in DatabaseInterface::postConnect
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Oct 10, 2017

Remove is_superuser superglobal
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Oct 10, 2017

Remove cell_align_left superglobal
It can be replaced by proper CSS.

Issue #11731
Issue #12262

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Oct 10, 2017

Remove cell_align_right superglobal
It can be replaced by proper CSS.

Issue #11731
Issue #12262

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Oct 10, 2017

Avoid using PMA_BYPASS_GET_INSTANCE
We can use Response::disable instead.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Oct 20, 2017

Move request check to helper method
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit to nijel/phpmyadmin that referenced this issue Oct 20, 2017

Move authentication logic to AuthenticationPlugin
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit to nijel/phpmyadmin that referenced this issue Oct 20, 2017

Move allow/deny rules check to AuthenticationPlugin
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit to nijel/phpmyadmin that referenced this issue Oct 20, 2017

Move authentication logic to AuthenticationPlugin
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit to nijel/phpmyadmin that referenced this issue Oct 20, 2017

Move allow/deny rules check to AuthenticationPlugin
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Oct 23, 2017

Move timezone setup to the DatabaseInterface
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Nov 27, 2017

Remove global variables cleanup
This should be no longer necessary, it was really a workaround for
grab_globals, which is not present in PHP for years.

See ee38250

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Nov 27, 2017

Move goto_whitelist to the core class
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Nov 27, 2017

Use generic PHPMYADMIN define to avoid CSS exection
It should work pretty much same, but we really don't care which of these
is set for rendering the css.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Nov 27, 2017

Move storage zeroconfig to the DBI post connect
This way it is executed only when needed.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Nov 27, 2017

Remove hack for navigation and server switching
It is not really used with current navigation, so this code has no use
for years.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Nov 27, 2017

Load user preferences at one place
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>

@nijel nijel added this to the 4.8.0 milestone Nov 27, 2017

@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Nov 27, 2017

Member

I think it is as good as it can be right now - the file is less than half lines it used to be and there is just one condition for the minimal inclusion.

Member

nijel commented Nov 27, 2017

I think it is as good as it can be right now - the file is less than half lines it used to be and there is just one condition for the minimal inclusion.

@nijel nijel closed this Nov 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment