Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up common.inc.php #11731

Closed
nijel opened this issue Dec 8, 2015 · 5 comments
Closed

Split up common.inc.php #11731

nijel opened this issue Dec 8, 2015 · 5 comments
Assignees
Labels
Milestone

Comments

@nijel
Copy link
Member

@nijel nijel commented Dec 8, 2015

Currently common.inc.php contains quite a lot of if cases for "minimal" inclusion. It should be split into two separate files, one doing the "minimal" set of things and second one the others on top of it. This way we can get rid of the PMA_MINIMUM_COMMON define and make the code cleaner.

@nijel nijel added the refactoring label Dec 8, 2015
@nijel nijel self-assigned this Dec 9, 2015
nijel added a commit that referenced this issue Dec 9, 2015
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Dec 9, 2015
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Dec 9, 2015
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
@wadhwasahil

This comment has been minimized.

Copy link

@wadhwasahil wadhwasahil commented Feb 19, 2016

Can I take up this issue?

@nijel

This comment has been minimized.

Copy link
Member Author

@nijel nijel commented Feb 19, 2016

As you can see it's assigned ;-). Anyway I'm slowly progressing with this (slowly mostly due to doing lot of other cleanups on the way).

@wadhwasahil

This comment has been minimized.

Copy link

@wadhwasahil wadhwasahil commented Feb 19, 2016

So, can I collaborate?

@nijel

This comment has been minimized.

Copy link
Member Author

@nijel nijel commented Feb 19, 2016

You can work on some tasks which will make this easier, eg. #11988 or #11989.

nijel added a commit that referenced this issue Mar 8, 2016
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Mar 8, 2016
Also removes ancient support for AIX iconv.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Mar 8, 2016
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Apr 11, 2016
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Apr 11, 2016
This allows us to load it only when needed

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Apr 11, 2016
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Dec 7, 2016
We already have the same information on Response object, so let's use it
from there.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Sep 4, 2017
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Sep 4, 2017
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit to nijel/phpmyadmin that referenced this issue Sep 5, 2017
This avoids loading them all into global namespace on every request.

Issue phpmyadmin#11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit to nijel/phpmyadmin that referenced this issue Sep 5, 2017
This avoids loading them all into global namespace on every request.

Issue phpmyadmin#11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit to nijel/phpmyadmin that referenced this issue Sep 5, 2017
This avoids loading them all into global namespace on every request.

Issue phpmyadmin#11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit to nijel/phpmyadmin that referenced this issue Sep 5, 2017
This avoids loading them all into global namespace on every request.

Issue phpmyadmin#11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Sep 5, 2017
This avoids loading them all into global namespace on every request.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit to nijel/phpmyadmin that referenced this issue Sep 6, 2017
…forms.php

Issue phpmyadmin#11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit to nijel/phpmyadmin that referenced this issue Oct 3, 2017
- move server selection from common.inc.php to Config class
- add tests covering most usual cases

Issue phpmyadmin#11731

Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel nijel mentioned this issue Oct 3, 2017
4 of 4 tasks complete
nijel added a commit to nijel/phpmyadmin that referenced this issue Oct 3, 2017
- move server selection from common.inc.php to Config class
- add tests covering most usual cases

Issue phpmyadmin#11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit to nijel/phpmyadmin that referenced this issue Oct 3, 2017
- move server selection from common.inc.php to Config class
- add tests covering most usual cases

Issue phpmyadmin#11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Oct 10, 2017
This wayt it's automatically passed with DBI.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Oct 10, 2017
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Oct 10, 2017
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Oct 10, 2017
It can be replaced by proper CSS.

Issue #11731
Issue #12262

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Oct 10, 2017
It can be replaced by proper CSS.

Issue #11731
Issue #12262

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Oct 10, 2017
We can use Response::disable instead.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Oct 20, 2017
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit to nijel/phpmyadmin that referenced this issue Oct 20, 2017
Issue phpmyadmin#11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit to nijel/phpmyadmin that referenced this issue Oct 20, 2017
Issue phpmyadmin#11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit to nijel/phpmyadmin that referenced this issue Oct 20, 2017
Issue phpmyadmin#11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit to nijel/phpmyadmin that referenced this issue Oct 20, 2017
Issue phpmyadmin#11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Oct 23, 2017
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Nov 27, 2017
This should be no longer necessary, it was really a workaround for
grab_globals, which is not present in PHP for years.

See ee38250

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Nov 27, 2017
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Nov 27, 2017
It should work pretty much same, but we really don't care which of these
is set for rendering the css.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Nov 27, 2017
This way it is executed only when needed.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Nov 27, 2017
It is not really used with current navigation, so this code has no use
for years.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Nov 27, 2017
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel

This comment has been minimized.

Copy link
Member Author

@nijel nijel commented Nov 27, 2017

I think it is as good as it can be right now - the file is less than half lines it used to be and there is just one condition for the minimal inclusion.

@nijel nijel closed this Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.