Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese language currently do not work in version 4.6.0 #12118

Closed
xdqi opened this issue Mar 23, 2016 · 11 comments

Comments

Projects
None yet
5 participants
@xdqi
Copy link

commented Mar 23, 2016

Steps to reproduce

  1. download phpMyAdmin-4.6.0-all-languages.zip from official site
  2. extract it on web server
  3. change language on login page of phpmyadmin to Chinese (either simplified or traditional version)

Expected behaviour

Page should show in Chinese

Actual behaviour

Page showed in English

Server configuration

Operating system: Arch Linux

Web server: Nginx 1.9.12

Database: 10.1.12-MariaDB - MariaDB Server

PHP version: 7.0.4

phpMyAdmin version: 4.6.0

Client configuration

Browser: Google Chrome 49.0.2623.87 (64-bit)

Operating system: OS X Yosemite 10.10.5

@ibennetch

This comment has been minimized.

Copy link
Member

commented Mar 23, 2016

This appears to also affect master, see for instance http://demo.phpmyadmin.net/master . I'm not yet sure what the cause is, but it appears more widespread than just the current release.

@madhuracj madhuracj self-assigned this Mar 24, 2016

@madhuracj madhuracj added the bug label Mar 24, 2016

@madhuracj

This comment has been minimized.

Copy link
Member

commented Mar 24, 2016

This seems to be a web server specific issue as I am unable to reproduce the issue on Apache. Also note that our demo server runs on nginx/1.6.2

@madhuracj madhuracj removed their assignment Mar 24, 2016

@nijel nijel added this to the 4.6.1 milestone Mar 24, 2016

@nijel nijel self-assigned this Mar 24, 2016

@nijel

This comment has been minimized.

Copy link
Member

commented Mar 24, 2016

The problem seems to be rather filesystem specific - it is broken on case sensitive filesystems.

The problem is with all two parts locales (eg. pt_BR is broken as well). This is due to fact that language codes are lower case while filenames use mixed case...

@nijel nijel closed this in 5d755b1 Mar 24, 2016

@neko2891

This comment has been minimized.

Copy link

commented Mar 31, 2016

Version 4.6.0
image

image

@neko2891

This comment has been minimized.

Copy link

commented Mar 31, 2016

Version 4.4.15
image

@nijel

This comment has been minimized.

Copy link
Member

commented Apr 5, 2016

@neko2891 It should be already fixed in Git.

@neko2891

This comment has been minimized.

Copy link

commented Apr 5, 2016

@nijel OK, thanks.

@ibennetch

This comment has been minimized.

Copy link
Member

commented May 5, 2016

I think this is not fully resolved:

  1. Log in to phpMyAdmin
  2. Select a different language from the dropdown (I've been able to reproduce with Chinese Simplified, Chinese Traditional, and English (United Kingdom); I was unable to reproduce with Dutch or German
  3. After a moment, the error message is shown:

Error in processing request
Error code: 200
Error text: Ok

I can dismiss the text, but then any action takes me to the login page -- presented in English.

Note that I don't get the error text with English (United Kingdom), but attempting any action results in me being logged out.

Trying a different method: from the login page, select Chinese Traditional from the dialog. The page seems to change correctly. Enter credentials and attempt to log in. I'm sent to the main phpMyAdmin page in English.

Version information

phpMyAdmin 4.6.1 and master
My Debian server (Apache) and the official demo server

@neko2891

This comment has been minimized.

Copy link

commented May 5, 2016

I think the problem is that the language codes
Uppercase and lowercase inconsistency
Some places zh_TW, some places zh_tw
In 4.6.0, in the "locale" subdirectory name all lowercase, you can switch languages
4.6.1 However, it can not

Login page, it has a problem to switch languages

@neko2891

This comment has been minimized.

Copy link

commented May 5, 2016

about Language codes https://www.w3.org/TR/REC-html40/struct/dirlang.html#h-8.1.1
language-code = primary-code ( "-" subcode )*
Two-letter primary codes are reserved for [ISO639] language abbreviations. Two-letter codes include fr (French), de (German), it (Italian), nl (Dutch), el (Greek), es (Spanish), pt (Portuguese), ar (Arabic), he (Hebrew), ru (Russian), zh (Chinese), ja (Japanese), hi (Hindi), ur (Urdu), and sa (Sanskrit).

Any two-letter subcode is understood to be a [ISO3166] country code.

zh_tw usage is wrong, correct it should be zh_TW

about ISO3166 https://en.wikipedia.org/wiki/ISO_3166-1

@nijel

This comment has been minimized.

Copy link
Member

commented May 11, 2016

On what platform is that? In the locale directory the directories should be mixed case, at least that is what I see if I download the archive...

@nijel nijel modified the milestones: 4.6.2, 4.6.1 May 11, 2016

@nijel nijel closed this in 63c89d2 May 11, 2016

007durgesh219 added a commit to 007durgesh219/phpmyadmin that referenced this issue May 16, 2016

Fixed setting mixed case languages
Switched to use same code in both approaches to set language.

Fixes phpmyadmin#12118

Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.