New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline styles #12262

Open
nijel opened this Issue May 17, 2016 · 16 comments

Comments

Projects
None yet
@nijel
Member

nijel commented May 17, 2016

Inline stying doesn't play well with themes and also forces us to use permisive Content-Security-Policy.

The styling should be moved completely to themes and after this is done the CSP should remove 'unsafe-inline' for styles.

@flash1452

This comment has been minimized.

Contributor

flash1452 commented May 17, 2016

@nijel Does fixing this error include even those inline style statements that are used in some of the .js files??
And also I wanted to ask if I am allowed to use any id or class-name for those tags that have yet not been given any class or id names.

@nijel

This comment has been minimized.

Member

nijel commented May 17, 2016

Yes to both answers. The definite goal is to remove inline usage from Conent-Security-Policy.

@nijel

This comment has been minimized.

Member

nijel commented May 18, 2016

Also this doesn't have to be done all in one step, incremental patches are welcome!

andavies pushed a commit to andavies/phpmyadmin that referenced this issue May 26, 2016

Andy Davies
Remove inline styles from elements with id='filterText' (partial fix …
…of issue phpmyadmin#12262)

Signed-off-by: Andy Davies <contact@andy-davies.me>

andavies pushed a commit to andavies/phpmyadmin that referenced this issue May 26, 2016

Andy Davies
Remove inline styles from elements with id='filterText' (partial fix …
…of issue phpmyadmin#12262)

Signed-off-by: Andy Davies <contact@andy-davies.me>

nijel added a commit that referenced this issue May 27, 2016

Merge pull request #12275 from andavies/issue-#12262
Remove inline styles from elements with id='filterText' (partial fix …

clancelotti added a commit to clancelotti/phpmyadmin that referenced this issue Dec 17, 2016

Remove inline styles from elements with id='serverstatusquerieschart_…
…data'(partial fix of issue phpmyadmin#12262)

Signed-off-by: Cristiano Lancelotti <lancelot.info@gmail.com>

clancelotti added a commit to clancelotti/phpmyadmin that referenced this issue Dec 20, 2016

Remove inline styles from elements with id='serverstatusquerieschart_…
…data'(partial fix of issue phpmyadmin#12262)

Signed-off-by: Cristiano Lancelotti <lancelot.info@gmail.com>

@nijel nijel referenced this issue Feb 2, 2017

Closed

db_central_columns: new column collapsing issue #12939

4 of 4 tasks complete

@nijel nijel added the hardening label Mar 16, 2017

@emanuelb

This comment has been minimized.

emanuelb commented May 17, 2017

here list of style attribute usage: (use class or css via id instead)

./gis_data_editor.php:echo '<div id="placeholder" style="width:450px;height:300px;'
./gis_data_editor.php:echo '<div id="openlayersmap" style="width:450px;height:300px;'
./gis_data_editor.php:echo '<div class="choice" style="float:right;clear:right;">';
./index.php:        echo '<p style="margin: 0.5em 1em 0.5em 1em">';
./prefs_manage.php:            <div class="click-hide-message group-cnt" style="display:none">
./prefs_manage.php:                <div style="padding-bottom:0.5em">
./templates/error/report_form.twig:    <fieldset style="padding-top:0">
./templates/columns_definitions/column_name.phtml:    <p style="font-size:80%;margin:5px 2px"
./templates/database/designer/having_query_panel.twig:<table id="query_having" style="display:none;" width="5%" cellpadding="0" cellspacing="0">
./templates/database/designer/aggregate_query_panel.twig:<table id="query_Aggregate" style="display:none;" width="5%" cellpadding="0" cellspacing="0">
./templates/database/designer/side_menu.phtml:    <div id="name-panel" style="overflow:hidden">
./templates/database/designer/side_menu.phtml:        <span id="page_name" style="border:none">
./templates/database/designer/side_menu.phtml:        <span id="saved_state" style="border:none">
./templates/database/designer/database_tables.phtml:           style="position:absolute; left:<?= (isset($tab_pos[$t_n])
./templates/database/designer/database_tables.phtml:                               style="margin: 0;"
./templates/database/designer/database_tables.phtml:        <tbody id="id_tbody_<?= $t_n_url; ?>" style="<?= (isset($tab_pos[$t_n]) && empty($tab_pos[$t_n]["V"])) ? 'display: none' : ''; ?>">
./templates/database/designer/database_tables.phtml:                                   style="margin: 0;"
./templates/database/designer/new_relation_panel.twig:<table id="layer_new_relation" style="display:none;" width="5%" cellpadding="0" cellspacing="0">
./templates/database/designer/delete_relation_panel.twig:<table id="layer_upd_relation" style="display:none;" width="5%" cellpadding="0" cellspacing="0">
./templates/database/designer/table_list.phtml:<div id="layer_menu" style="display:none;">
./templates/database/designer/table_list.phtml:        <table width="100%" style="padding-left: 3px;">
./templates/database/designer/table_list.phtml:                               style="margin:0;"
./templates/database/designer/rename_to_panel.twig:<table id="query_rename_to" style="display:none;" width="5%" cellpadding="0" cellspacing="0">
./templates/database/designer/query_details.phtml:    <div style="clear:both;">
./templates/database/designer/query_details.phtml:    <div style="clear:both;">
./templates/database/designer/options_panel.twig:<table id="pmd_optionse" style="display:none;" width="5%" cellpadding="0" cellspacing="0">
./templates/database/designer/where_query_panel.twig:<table id="query_where" style="display:none;" width="5%" cellpadding="0" cellspacing="0">
./templates/database/structure/check_all_tables.phtml:    <select name="submit_mult" style="margin: 0 3em 0 3em;">
./templates/div_for_slider_effect.twig:        style="display: none; overflow:auto;"{% endif %} class="pma_auto_slider"
./templates/privileges/require_options.phtml:                <div id="specified_div" style="padding-left:20px;">
./templates/server/databases/table_row.phtml:        <td class="tool" style="text-align: center;">
./templates/server/databases/table_row.phtml:        <td class="tool" style="text-align: center;">
./templates/server/variables/link_template.phtml:<a style="display: none;" href="<?= $url; ?>" class="ajax saveLink">
./templates/server/variables/link_template.phtml:<a style="display: none;" href="#" class="cancelLink">
./templates/table/gis_visualization/gis_visualization.phtml:        <div id="gis_div" style="position:relative;">
./templates/table/gis_visualization/gis_visualization.phtml:            <div class="pma_quick_warp" style="width: 50px; position: absolute; right: 0; top: 0; cursor: pointer;">
./templates/table/gis_visualization/gis_visualization.phtml:                    <span class="drop_button" style="padding: 0; border: 0;">
./templates/table/gis_visualization/gis_visualization.phtml:        <div style="clear:both;">&nbsp;</div>
./templates/table/gis_visualization/gis_visualization.phtml:             style="width:<?= htmlspecialchars($visualizationSettings['width']); ?>
./templates/table/structure/move_columns_dialog.phtml:<div id="move_columns_dialog" title="<?= __('Move columns'); ?>" style="display: none">
./templates/table/structure/optional_action_links.phtml:            ); ?>" style="margin-right: 0;">
./templates/table/chart/tbl_chart.phtml:                <span class="span_pie" style="display:none;">
./templates/table/chart/tbl_chart.phtml:                <span class="span_timeline" style="display:none;">
./templates/table/chart/tbl_chart.phtml:                <span class="span_scatter" style="display:none;">
./templates/table/chart/tbl_chart.phtml:                <span class="barStacked" style="display:none;">
./templates/table/chart/tbl_chart.phtml:                <input style="margin-top:0;" type="text" name="xaxis_label"
./templates/table/chart/tbl_chart.phtml:            <p style="clear:both;">&nbsp;</p>
./templates/table/chart/tbl_chart.phtml:            <p style="clear:both;">&nbsp;</p>
./templates/table/chart/tbl_chart.phtml:            <div id="resizer" style="width:600px; height:400px;">
./templates/table/chart/tbl_chart.phtml:                <div style="position: absolute; right: 10px; top: 10px; cursor: pointer; z-index: 1000;">
./templates/table/search/options.phtml:<br style="clear: both;" />
./templates/table/search/zoom_result_form.phtml:                    <div id="querydata" style="display:none">
./templates/table/search/zoom_result_form.phtml:        <div id="dataDisplay" style="display:none">
./templates/prefs_autoload.twig:<div id="prefs_autoload" class="notice print_ignore" style="display:none">
./templates/select_all.twig:<i style="margin-left: 2em">{% trans 'With selected:' %}</i>
./themes/svg_gradient.php:    <rect width="100%" height="100%" style="fill:url(#linear-gradient);" />
./libraries/Util.php:                . ' style="text-align: ' . $GLOBALS['cell_align_left'] . '"'
./libraries/Util.php:                     . ' method="post"' . $target . ' style="display: inline;">';
./libraries/Util.php:                $selected = 'selected="selected" style="font-weight: bold"';
./libraries/Util.php:            . '<div id="upload_form_status" style="display: none;"></div>'
./libraries/Util.php:            . '<div id="upload_form_status_info" style="display: none;"></div>'
./libraries/Util.php:                . '    <select style="margin: 5px" size="1" '
./libraries/config/FormDisplay.tpl.php:            . '" style="display:none">' . $icons['edit'] . '</a>';
./libraries/config/FormDisplay.tpl.php:            .  __('Restore default value') . '" style="display:none">'
./libraries/sql.lib.php:        $profiling_table .= '<div id="profilingChartData" style="display:none;">';
./libraries/sql.lib.php:        $profiling_table .= '<div id="profilingchart" style="display:none;">';
./libraries/sql.lib.php:            . 's<span style="display:none;" class="rawvalue">'
./libraries/sql.lib.php:            . 's<span style="display:none;" class="rawvalue">'
./libraries/sql.lib.php:            . 's<span style="display:none;" class="rawvalue">'
./libraries/DbQbe.php:        $html_output .= '<select style="width: ' . $this->_realwidth
./libraries/DbQbe.php:                    . ' style="width: ' . $this->_realwidth . '"'
./libraries/DbQbe.php:                . ' style="width: ' . $this->_realwidth . '"'
./libraries/DbQbe.php:                    . ' style="width: ' . $this->_realwidth . '" size="20" />';
./libraries/DbQbe.php:                . ' style="width: ' . $this->_realwidth . '" size="20" />';
./libraries/DbQbe.php:        $html_output .= '<table class="data" style="width: 100%;">';
./libraries/DbQbe.php:        $html_output .= '<div class="floatleft" style="width:50%">';
./libraries/navigation/Navigation.php:                        $html .= '<td style="width:80px"><a href="navigation.php'
./libraries/server_status_variables.lib.php:        $retval .= '<span style="display:none;" class="original">';
./libraries/server_status_advisor.lib.php:    $output .= '<div id="advisorInstructionsDialog" style="display:none;">';
./libraries/server_status_advisor.lib.php:    $output .= '<div id="advisorData" style="display:none;">';
./libraries/tracking.lib.php:        <th style="width: 300px"><?php echo __('Table');?></th>
./libraries/central_columns.lib.php:    $table_navigation_html = '<table style="display:inline-block;max-width:49%" '
./libraries/central_columns.lib.php:        . '<th class="" style="display:none"></th>'
./libraries/central_columns.lib.php:        . ' style="min-width: 100%;">';
./libraries/central_columns.lib.php:    $columnAdd = '<table style="display:inline-block;margin-left:1%;max-width:50%" '
./libraries/central_columns.lib.php:        . '<td style="padding:1.5% 0em">'
./libraries/central_columns.lib.php:        . '<td id="save_' . $row_num . '" style="display:none">'
./libraries/rte/rte_export.lib.php:            $export_data = '<textarea cols="40" rows="15" style="width: 100%;">'
./libraries/index.lib.php:    $html_output .= '<fieldset class="tblFooters print_ignore" style="text-align: '
./libraries/replication_gui.lib.php:        $html .= ' <div id="slave_control_gui" style="display: none">';
./libraries/replication_gui.lib.php:    $html .= ' <div id="slave_errormanagement_gui" style="display: none">';
./libraries/replication_gui.lib.php:    $html .= '<div id="replication_' . $type . '_section" style="';
./libraries/replication_gui.lib.php:    $html .= '  <div id="replication_slaves_section" style="';
./libraries/DatabaseInterface.php:                = '<span style="color:red">'
./libraries/display_export.lib.php:    $html .= '<div class="floatleft" style="margin-left: 50px;">';
./libraries/insert_edit.lib.php:        return '<span style="border-bottom: 1px dashed black;" title="'
./libraries/insert_edit.lib.php:        return '<span style="color:red">' . __('Error') . '</span><br />' . "\n"
./libraries/plugins/auth/AuthenticationConfig.php:    <table cellpadding="0" cellspacing="3" style="margin: 0 auto" width="80%">
./libraries/plugins/schema/dia/TableStatsDia.php:                <dia:font family="monospace" style="0" name="Courier"/>
./libraries/plugins/schema/dia/TableStatsDia.php:                <dia:font family="sans" style="80" name="Helvetica-Bold"/>
./libraries/plugins/schema/dia/TableStatsDia.php:                <dia:font family="sans" style="0" name="Helvetica"/>
./libraries/plugins/schema/dia/RelationStatsDia.php:                <dia:font family="monospace" style="0" name="Courier"/>
./libraries/server_status_monitor.lib.php:    $retval .= __('Log statistics') . '" style="display:none;">';
./libraries/server_status_monitor.lib.php:    $retval .= __('Query analyzer') . '" style="display:none;">';
./libraries/server_status_monitor.lib.php:    $retval .= __('Monitor Instructions') . '" style="display:none;">';
./libraries/server_status_monitor.lib.php:    $retval .= '<div class="monitorUse" style="display:none;">';
./libraries/server_status_monitor.lib.php:        . __('Add chart') . '" style="display:none;">';
./libraries/server_status_monitor.lib.php:    $retval .= '<span class="divisorInput" style="display:none;">';
./libraries/server_status_monitor.lib.php:    $retval .= '<span class="unitInput" style="display:none;">';
./libraries/server_status_monitor.lib.php:    $retval .= '<span id="clearSeriesLink" style="display:none;">';
./libraries/server_status_monitor.lib.php:    $retval .= '<a href="#endChartEditMode" style="display:none;">';
./libraries/display_import.lib.php:        . 'width="1" height="1" style="display: none;"></iframe>';
./libraries/display_import.lib.php:    $html .= '<div id="import_form_status" style="display: none;"></div>';
./libraries/display_import.lib.php:        . 'width="16" height="16" alt="ajax clock" style="display: none;" />';
./libraries/server_user_groups.lib.php:        $html_output .= '<th style="white-space: nowrap">'
./libraries/ErrorHandler.php:                $retval .= ' style="display:none;"';
./libraries/export.lib.php:    $html = '<div style="text-align: ' . $GLOBALS['cell_align_left'] . '">';
./libraries/server_privileges.lib.php:        . ' name="user_exists_warning" style="display:none;">'
./libraries/server_privileges.lib.php:                $html_output .= '<span style="color: #FF0000">'
./libraries/server_privileges.lib.php:                    ? '<span style="color: #FF0000">' . __('Any') . '</span>'
./libraries/server_privileges.lib.php:            $new_user_string .= '<span style="color: #FF0000">'
./libraries/server_privileges.lib.php:        . '<div class="clear_both" style="clear:both"></div>';
./libraries/server_privileges.lib.php:                    ? '<span style="color: #FF0000">' . __('Any') . '</span>'
./libraries/server_privileges.lib.php:                $html_output .= '<span style="color: #FF0000">' . __('No')
./libraries/relation.lib.php:    $messages['error'] = '<span style="color:red"><strong>'
./libraries/relation.lib.php:    $messages['ok'] = '<span style="color:green"><strong>'
./libraries/relation.lib.php:    $messages['enabled']  = '<span style="color:green">' . __('Enabled') . '</span>';
./libraries/relation.lib.php:    $messages['disabled'] = '<span style="color:red">'   . __('Disabled') . '</span>';
./libraries/DisplayResults.php:            . '<i style="margin-left: 2em">' . __('With selected:') . '</i>' . "\n";
./setup/frames/config.inc.php:echo '<td class="lastrow" style="text-align: left">';
./setup/frames/index.inc.php:echo '<a href="#" id="show_hidden_messages" style="display:none">';
./setup/frames/index.inc.php:    echo '<table cellspacing="0" class="datatable" style="table-layout: fixed">';
./setup/frames/index.inc.php:        echo '<td style="white-space: nowrap">';
./setup/frames/index.inc.php:echo '<td class="lastrow" style="text-align: left">';
./setup/frames/index.inc.php:echo '<td colspan="2" class="lastrow" style="text-align: left">';
./js/messages.php:    . '" class="floatright" style="margin-top: 20px;">'
./js/messages.php:    . '" class="floatright" style="margin-top: 20px;">'
./js/server_status_monitor.js:                ' style="width:' + chartSize.width + 'px; height:' + chartSize.height + 'px;"></div>' +
./js/server_status_monitor.js:            var tooltipHtml = '<div style="font-size:12px;background-color:#FFFFFF;' +
./js/server_status_monitor.js:            tooltipHtml += '<span style="font-weight:bold;">';
./js/server_status_monitor.js:                tooltipHtml += '<br /><span style="color:' + seriesColor + '">' +
./js/server_status_monitor.js:            var selectionBox = $('<div id="selection_box" style="z-index:1000;height:205px;position:absolute;background-color:#87CEEB;opacity:0.4;
./js/server_status_monitor.js:                        '        <input name="filterQueryText" type="text" id="filterQueryText" style="vertical-align: baseline;" />' +
./js/error_report.js:            '<div style="position:fixed;bottom:0;left:0;right:0;margin:0;' +
./js/functions.js:            fields += '<tr><td><div><span style="font-weight:bold">' +
./js/functions.js:                '</span><br><span style="color:gray">' + central_column_list[db + '_' + table][i].col_type;
./js/functions.js:                fields += '<td><input class="pick" style="width:100%" type="submit" value="' +
./js/functions.js:                        fields += '<tr><td><div><span style="font-weight:bold">' +
./js/functions.js:                            '</span><br><span style="color:gray">' +
./js/functions.js:                            fields += '<td><input class="pick" style="width:100%" type="submit" value="' +
./js/pmd/history.js:            str += '<td style="padding-left: 5px;" class="right">' + PMA_getImage('b_sbrowse.png', 'column name') + '</td>' +
./js/pmd/history.js:                '<td width="175" style="padding-left: 5px">' + history_array[i].get_column_name() + '<td>';
./js/rte.js:                data.message = '<textarea cols="40" rows="15" style="width: 100%;">' + data.message + '</textarea>';

here list of <style> tag usage: (use link to load css file instead)

./libraries/Header.php:                $retval .= '<style>html{display:block}</style>';
./libraries/Header.php:            $retval .= '<style id="cfs-style">html{display: none;}</style>';
./libraries/error.inc.php:    <style type="text/css">

@mauriciofauth mauriciofauth referenced this issue May 23, 2017

Merged

Remove some inline CSS #13293

4 of 4 tasks complete

@nijel nijel referenced this issue Jul 24, 2017

Merged

Interface design for Multi-table query #13342

3 of 4 tasks complete
@codehimanshu

This comment has been minimized.

Contributor

codehimanshu commented Aug 3, 2017

@nijel Please let me know if the inline styles are still existing. I would like to work on it.

@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Aug 3, 2017

@codehimanshu Thanks for the interest. There are still inline styles in some places.
Feel free to choose what you want to remove and send us a pull request.

@codehimanshu

This comment has been minimized.

Contributor

codehimanshu commented Aug 3, 2017

@mauriciofauth I am a newbee, so I need a bit guidence.
I want to remove inline style from /js/error_report.js
var $div = $( '<div style="position:fixed;bottom:0;left:0;right:0;margin:0;' + 'z-index:1000" class="error" id="error_notification"></div>'
Should I add a class here and add this particular css in /themes/original/css/common.css.php and /themes/pmahomme/css/common.css.php?

codehimanshu added a commit to codehimanshu/phpmyadmin that referenced this issue Aug 4, 2017

partial fix issue phpmyadmin#12262
Signed-off-by: codehimanshu <himanshuagrawal1998@gmail.com>

codehimanshu added a commit to codehimanshu/phpmyadmin that referenced this issue Aug 4, 2017

remove trailing whitespaces phpmyadmin#12262
Signed-off-by: codehimanshu <himanshuagrawal1998@gmail.com>

mauriciofauth added a commit that referenced this issue Aug 5, 2017

@Nilucshan

This comment has been minimized.

Nilucshan commented Aug 28, 2017

I would like to work on removing inline and i am also a newbie. I am not clear about what we are supposed to do when we remove those inline codes. Can anyone assist with this? Any help is highly appreciated.

@codehimanshu

This comment has been minimized.

Contributor

codehimanshu commented Aug 28, 2017

@Nilucshan You can remove the inline css codes and add a class or ID to the element. Then apply the same CSS in the css files in themes/pmahomme/css/common.css.php Also check the layout on browser if poosible. Refer to any of the above PRs for help.

@mauriciofauth mauriciofauth referenced this issue Sep 12, 2017

Merged

Added refresh button in export #13674

4 of 4 tasks complete

Juvenv added a commit to Juvenv/phpmyadmin that referenced this issue Dec 25, 2017

Removed last inline style from rte.js phpmyadmin#12262
Signed-off-by: Juvenildo Vaz <juvenildo1511@yahoo.com.br>

Juvenv added a commit to Juvenv/phpmyadmin that referenced this issue Dec 25, 2017

Removed all remaining inline styles from functions.js phpmyadmin#12262
Signed-off-by: Juvenildo Vaz <juvenildo1511@yahoo.com.br>

@Juvenv Juvenv referenced this issue Dec 25, 2017

Merged

Remove inline styles from elements #13888

4 of 4 tasks complete

williamdes added a commit to williamdes/phpmyadmintest that referenced this issue Dec 27, 2017

Remove inline styles from messages.php phpmyadmin#12262
Signed-off-by: Juvenildo Vaz <juvenildo1511@yahoo.com.br>

williamdes added a commit to williamdes/phpmyadmintest that referenced this issue Dec 27, 2017

Removed last inline style from rte.js phpmyadmin#12262
Signed-off-by: Juvenildo Vaz <juvenildo1511@yahoo.com.br>

williamdes added a commit to williamdes/phpmyadmintest that referenced this issue Dec 27, 2017

Removed all remaining inline styles from functions.js phpmyadmin#12262
Signed-off-by: Juvenildo Vaz <juvenildo1511@yahoo.com.br>

Anu4ruby added a commit to Anu4ruby/phpmyadmin that referenced this issue Feb 9, 2018

mauriciofauth added a commit that referenced this issue Mar 24, 2018

Remove inline styles in ReplicationGui.php (#13981)
* removed inline styles from AuthenticationConfig.php file-issue 12262

* removed inline styles from AuthenticationConfig.php- file-issue 12262-Signed-off-by: Anupama.V <sadicarnot@gmail.com>

* Remove inline styles from ReplicationGui.php #12262.

Signed-off by: Anupama.V <sadicarnot@gmail.com>

@mohitjawanjal mohitjawanjal referenced this issue Mar 28, 2018

Merged

Remove inline styles from Relation.php #14141

4 of 4 tasks complete
@rijaspk

This comment has been minimized.

Contributor

rijaspk commented Apr 2, 2018

hi, @mauriciofauth. Is inline styles are still existing. I would like to work on it. Please share the list of styles

@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Apr 2, 2018

Hi, @rijaspk. Yes, inline styles still exist in code. Just search for the style attribute.
For example:

$retval .= "<table class='rte_table' style='width: 100%'>\n";
$retval .= "<tr>\n";
$retval .= " <td style='width: 20%;'>" . __('Routine name') . "</td>\n";

mauriciofauth added a commit that referenced this issue Sep 29, 2018

Issue #12262 - Removing inline styles (#14638)
Signed-off-by: Victor Farias <victor.f.farias@gmail.com>
@chinela

This comment has been minimized.

chinela commented Oct 15, 2018

Hi am a newbie...
I've been on github for months and I don't know what it is.
I would like to contribute so please put me through

@nborschke

This comment has been minimized.

nborschke commented Oct 16, 2018

Hey, i already removed some inline styles in my local branch but i am not sure how and to which branch i should commit and push to. Could someone give me a short explanation ?

@williamdes

This comment has been minimized.

Member

williamdes commented Oct 16, 2018

@nborschke @chinela You can fork the phpmyadmin repository and start contributing on your fork of this repository.
Then create a pull-request: https://help.github.com/articles/creating-a-pull-request/
You can join our Slack or Gitter

@LillyMich

This comment has been minimized.

LillyMich commented Oct 16, 2018

Hi, I am newbie and I would like to contribute with this issue. Is that okey?

@stephanfx

This comment has been minimized.

Contributor

stephanfx commented Oct 18, 2018

I see that the travis CI failed on the docs section of the build, is this an issue with the code I submitted?

@williamdes williamdes added the has-pr label Oct 25, 2018

@stephanfx stephanfx referenced this issue Nov 1, 2018

Merged

style: remove inline styles from function.js #14701

6 of 6 tasks complete

@CXZ7720 CXZ7720 referenced a pull request that will close this issue Nov 8, 2018

Open

remove inline styles from server_status_monitor.js #14714

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment