New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme selection for future releases #12373

Closed
nijel opened this Issue Jul 8, 2016 · 5 comments

Comments

Projects
None yet
5 participants
@nijel
Member

nijel commented Jul 8, 2016

I think it's time to reconsider which themes are shipped with phpMyAdmin. The Original theme is really showing it's age also it might be good idea to include Metro which is IMHO way nicer.

@nijel nijel added the enhancement label Jul 8, 2016

@nijel nijel referenced this issue Jul 8, 2016

Closed

Add Themes #37

@alextech

This comment has been minimized.

alextech commented Jul 22, 2016

As long as have a choice. Pmahomme at least should remain. I stopped updating frontend software in past year or moved to alternatives of those switching to flat UI like Metro.

@Lyko93

This comment has been minimized.

Lyko93 commented Aug 12, 2016

In my free time I was thinking about seeing what I can do with Semantic UI for a theme.

@nijel

This comment has been minimized.

Member

nijel commented Jan 23, 2017

This issue was a bit forgotten, but maybe it's not too late to reopen this for 4.7, given that 4.7.0-beta1 should be out soon. On the other side with beta out, the theme developers might have good chance to work on their themes to fix any possible issues with 4.7 branch.

However I'd really like to have new theme as current one is really showing it's age. On the other side we have huge amount of conservative users still preferring the original theme (which was replaced by pmahome as default more than six years ago, see #5959 and #6050), so I'm not really sure if we're going to add another theme (what would be additional maintenance burden) or replace one of the existing ones (and receive negative feedback about removing theme people are used to).

Overall there are quite some things to decide :-).

In the end what might be doable plan:

  • Release 4.7.0 with current set of themes.
  • Target 5.0.0 as next major version to be released in few months. This assumes no theme related changes will happen between these two releases.
  • Open theme contest just after releasing 4.7.0-beta1.
  • Vote for themes to include in 5.0.0 after releasing 4.7.0.

Given our current two months release schedule that could be:

  • End of January
    • 4.7.0-beta1 is released
    • Theme contest is announced
  • End of March
    • 4.7.0 is released
    • Theme submission deadline
    • Voting for themes is started
  • End of April
    • Theme voting deadline
  • End of May
    • 5.0.0 is released with new theme

What does @phpmyadmin/developers think?

@smartcorestudio

This comment has been minimized.

smartcorestudio commented Feb 7, 2017

New theme is MUCH needed. The sooner - the better

@alextech

This comment has been minimized.

alextech commented Feb 7, 2017

Its fine to do a refresh; new looks can be exciting, I used to look forward to visual improvements. Just don't make it mostly white space, too flat with sharp corners that I am afraid I'll cut myself if get too close to monitor, or icons that do not represent anything.

Eg. DbSchema looks nice https://www.colormango.com/development/screenshot/dbschema_112104.png
Or similar to ExtJS gray and classic themes http://examples.sencha.com/extjs/6.2.0/examples/kitchensink/?profile=gray#form-checkout

@nijel nijel changed the title from Theme selection for 4.7 to Theme selection for future releases Feb 9, 2017

mauriciofauth added a commit to mauriciofauth/phpmyadmin that referenced this issue Apr 19, 2018

Add Metro theme
Fix phpmyadmin#12373

See https://github.com/phpmyadmin/phpmyadmin/wiki/2017-04_Meeting

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

@mauriciofauth mauriciofauth referenced this issue Apr 19, 2018

Merged

Add Metro theme #14210

4 of 4 tasks complete

mauriciofauth added a commit to mauriciofauth/phpmyadmin that referenced this issue Apr 19, 2018

Add Metro theme
Fix phpmyadmin#12373

See https://github.com/phpmyadmin/phpmyadmin/wiki/2017-04_Meeting

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

@mauriciofauth mauriciofauth self-assigned this Apr 29, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Apr 29, 2018

mauriciofauth added a commit that referenced this issue May 4, 2018

Add ChangeLog entries for #12373 and #14155
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment