New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ./libraries/tbl_info.inc.php by moving it's code to Table class #12567
Comments
…mespace This is just a minor cleanup to avoid possible problems when MySQL create table options would collide with our variable names. See also issue #12567 Signed-off-by: Michal Čihař <michal@cihar.com>
Hello! I am new to open source and I would like to work on this issue and start contributing.Please can someone help me get started |
Look at the mentioned file and all places where it's used. You can see it currently sets dozen of global variables, where most of them are not really needed in all cases. The work can be done in few steps:
|
@nijel If no one is working on this issue I would like to take up this task. |
Probably nobody is working on this, so feel free to look at it. |
@nijel So what I am assuming is that we need to shift the code from tbl_info.inc.php to Table class and develop new methods to set the global variables like - $showtable, $tbl_is_view, $tbl_storage_engine etc. |
I'm not sure if global variables are really needed, you should look at their usage and probably move (some of) the method calls there. |
@nijel I have found two files that are including tbl_info.inc.php. First one is in $tbl_operations.php and second one is in TableChartController. TableChartController doesn't seem to use any of the variables that are set in tbl_info.inc.php. On the other hand tbl_operations.php uses $tbl_is_view, $auto_increment, $show_comment etc. |
Maybe some of it's methods access it as globals? Or it can be also used in the templates, so rather look for the variables themselves. |
There is
./libraries/tbl_info.inc.php
which does some basic preprocessing of table information and stores it into global variables.This code should be integrated into
Table
class and all callers adjusted to useTable
class directly instead of relying on the global variables./libraries/tbl_info.inc.php
currently sets.The text was updated successfully, but these errors were encountered: