Safari only: JavaScript error with User accounts tab #12829

Closed
ibennetch opened this Issue Dec 19, 2016 · 1 comment

Projects

None yet

2 participants

@ibennetch
Contributor

With current master, using only Safari, I get this JavaScript error when loading the User accounts tab.

{
    "pma_version": "4.7.0-dev",
    "browser_name": "SAFARI",
    "browser_version": "9.1.2",
    "user_os": "Mac",
    "server_software": "nginx/1.6.2",
    "user_agent_string": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/601.7.8 (KHTML, like Gecko) Version/9.1.2 Safari/601.7.7",
    "locale": "en",
    "configuration_storage": "enabled",
    "php_version": "7.0.14-1+0~20161212122340.19+jessie~1.gbp8dc455",
    "exception_type": "js",
    "exception": {
        "mode": "onerror",
        "message": "SyntaxError: Unexpected token '='. Expected a ')' or a ',' after a parameter declaration.",
        "stack": [
            {
                "line": 34,
                "column": "0",
                "func": "checkPasswordStrength",
                "context": [
                    "    }",
                    "",
                    "    return PMA_checkPassword($(the_form));",
                    "} // end of the 'checkAddUser()' function",
                    "",
                    "function checkPasswordStrength(value, meter_obj, meter_object_label, userna//...",
                    "    // List of words we don't want to appear in the password",
                    "    customDict = [",
                    "        'phpmyadmin',",
                    "        'mariadb',",
                    "        'mysql',"
                ],
                "filename": "server_privileges.js"
            }
        ],
        "name": "SyntaxError",
        "uri": "index.php?"
    },
    "script_name": "index.php",
    "microhistory": null
}

This problem doesn't occur with Firefox or Chrome.

@ibennetch
Contributor

Git bisect says that ac2cfef is the first bad commit.

However, there are several commits before that one where the "Add user account" link doesn't work.

@nijel nijel added this to the 4.7.0 milestone Dec 19, 2016
@nijel nijel added the bug label Dec 19, 2016
@nijel nijel self-assigned this Dec 19, 2016
@nijel nijel added a commit that closed this issue Dec 19, 2016
@nijel nijel Remove default value for js parameter
The null is there implicitely anyway.

Fixes #12829

Signed-off-by: Michal Čihař <michal@cihar.com>
b8b872d
@nijel nijel closed this in b8b872d Dec 19, 2016
@ragnerok ragnerok added a commit to ragnerok/phpmyadmin that referenced this issue Dec 21, 2016
@ragnerok ragnerok Update from original (#2)
* Do not delete session on fatal error

I see no reason why this should be done, the fatal error is used
in following cases:

* Very early when there is no session (eg. missing extension)
* Invalid value for parameters
* Invalid invocation like too big request

In neither case session removal will do any good.

Signed-off-by: Michal Čihař <michal@cihar.com>

* Do not use control link when working with stored procedures

Fixed stored procedure execution.

Fixes #12813

Signed-off-by: Michal Čihař <michal@cihar.com>

* Fix early fatal errors

We can not rely on whole stack being ready.

Fixes #12810

Signed-off-by: Michal Čihař <michal@cihar.com>

* Fix display of custom header and footer in certain edge cases.
Issues #12801 and #12802

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>

* Translated using Weblate (Dutch)

Currently translated at 100.0% (3222 of 3222 strings)

[CI skip]

* Translated using Weblate (Dutch)

Currently translated at 100.0% (3239 of 3239 strings)

[CI skip]

* Translated using Weblate (French)

Currently translated at 100.0% (3222 of 3222 strings)

[CI skip]

* Translated using Weblate (French)

Currently translated at 100.0% (3239 of 3239 strings)

[CI skip]

* Translated using Weblate (French)

Currently translated at 100.0% (3222 of 3222 strings)

[CI skip]

* MySQL allows precision to be specified for DATETIME, TIME type fields too

Fix #12814

Ref : http://dev.mysql.com/doc/refman/5.7/en/fractional-seconds.html

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>

* ChangeLog for #12814

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>

* Share code for cascading ajax flag

Signed-off-by: Michal Čihař <michal@cihar.com>

* Get response instance just once

Signed-off-by: Michal Čihař <michal@cihar.com>

* Register shutdown directly on singleton instance

This avoids additional call in the shutdown handler.

Signed-off-by: Michal Čihař <michal@cihar.com>

* Simplify checking for ajax request

Signed-off-by: Michal Čihař <michal@cihar.com>

* Include token in all filter requests

Fixes #12786

Signed-off-by: Michal Čihař <michal@cihar.com>

* Fix documentation markup

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>

* Hints about using Composer for library dependencies

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>

* Use documentation link instead of wiki for Composer details

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>

* Uncomment mistakenly commented Selenium testing setting

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>

* Translated using Weblate (Spanish)

Currently translated at 100.0% (3222 of 3222 strings)

[CI skip]

* Translated using Weblate (Spanish)

Currently translated at 99.8% (3234 of 3239 strings)

[CI skip]

* Remove .htaccess from tests

Issue #12348

Signed-off-by: Michal Čihař <michal@cihar.com>

* Add source release support

See #12348

Signed-off-by: Michal Čihař <michal@cihar.com>

* Share code for rendering custom header and footer

Fixes #12802

Signed-off-by: Michal Čihař <michal@cihar.com>

* Fix empty password login for http authetication

Fixes #12828

Signed-off-by: Michal Čihař <michal@cihar.com>

* Honor user configured connection collation

* the user set collation is now honored
* default value has been changed to utf8mb4
* it is downgraded to utf8 if server does not support it

Fixes #12826

Signed-off-by: Michal Čihař <michal@cihar.com>

* Fix HTTP auth test expectations

Signed-off-by: Michal Čihař <michal@cihar.com>

* Remove default value for js parameter

The null is there implicitely anyway.

Fixes #12829

Signed-off-by: Michal Čihař <michal@cihar.com>

* Add some missing html encoding

Issue #12804

Signed-off-by: Michal Čihař <michal@cihar.com>

* Feature: #12069: Filtering tables on table listing of particular database.

Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>

* Feature: #12069: Filtering tables on table listing of particular database.

Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>

* Determine whether to use openssl just once

Issue #12293

Signed-off-by: Michal Čihař <michal@cihar.com>

* Correctly report OpenSSL errors from cookie encryption

Without calling openssl_error_string() we pollute openssl global state
and some other library might report this as failure (eg. mysqlnd driver
when connecting to SSL enabled server).

Fixes #12293

Signed-off-by: Michal Čihař <michal@cihar.com>

* Use same encryption key with openssl and phpseclib

Issue #12293

Signed-off-by: Michal Čihař <michal@cihar.com>

* Test both with and without phpseclib

This ensures we generate compatible data in both cases.

Issue #12293

Signed-off-by: Michal Čihař <michal@cihar.com>

* Use Header class for headers manipulation

* Added mocking of response object
* Rectified mistake of calling method once
* implemented mock properly
* replaced header with response header 

Issue #12079

Signed-off-by: Osaid osaid.nasir@gmail.com

* Inline javascript codes are removed. Each is used for table search

Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>

* Update db_structure.js

* Tab spaces are removed.

Signed-off-by: Yunus Çağrı <ycagriyurdakul@gmail.com>

* Unbind event on page unload

Issue #12838, #12069

Signed-off-by: Michal Čihař <michal@cihar.com>

* Use existing filtering template for table filtering

Issue #12838, #12069

Signed-off-by: Michal Čihař <michal@cihar.com>

* Changelog for issues #12838 and #12069

Signed-off-by: Michal Čihař <michal@cihar.com>
a88ed64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment