quick search box from the top left corner does not work #12923

Closed
domnulnopcea opened this Issue Jan 24, 2017 · 18 comments

Projects

None yet

5 participants

@domnulnopcea
Contributor

quick search box from the top left corner does not work

put only 2-3 letter and press enter => it does not show the results that match the criteria

@ibennetch
Contributor

Hello, could you please tell us which phpMyAdmin version and which browser you are using?

@domnulnopcea
Contributor
@ibennetch
Contributor
ibennetch commented Jan 24, 2017 edited

Okay, thanks for your report.

It looks like the problem is actually the pressing of Enter. I'm actually not sure what is meant by "Enter to search all" in the tool tip hint here, so it's not clear to me what the intended behavior is when Enter is pressed. Probably in the end we should catch the press of Enter.

Present in 4.6.6 and current master and tested with Firefox and Chrome.

@devenbansod
Member

Hi @ibennetch, as we know, the navigation can be paged like maybe 30 items on the each page and so on.
The expected behavior is that If you enter any text in the filter-box, it automatically searches for the items on the page currently displayed in the navigation.
The hint 'Enter to search all' is suggesting that for searching all such nav-pages, user has to explicitly press Enter (which I guess involves an AJAX request to the server to get the results).

@ibennetch
Contributor
@nijel
Member
nijel commented Jan 25, 2017

I thought I've fixed that for 4.6.6, see #12786

@nijel nijel added the bug label Jan 25, 2017
@nijel
Member
nijel commented Jan 25, 2017

Okay, it does work at 1ae6275, but not in the release, something has to break that again. Somehow I'm unable to discover problematic commit with bisect.

@nijel
Member
nijel commented Jan 25, 2017

Okay, the problematic commit is 7bf85fe.

@nijel nijel self-assigned this Jan 25, 2017
@nijel
Member
nijel commented Jan 25, 2017

As a workaround you can set

$cfg['Servers'][$i]['DisableIS'] = true;
@nijel nijel added a commit that closed this issue Jan 25, 2017
@nijel nijel Fix navigation panel server side search
Fixes #12923

Signed-off-by: Michal Čihař <michal@cihar.com>
20a5e25
@nijel nijel closed this in 20a5e25 Jan 25, 2017
@nijel nijel added a commit that referenced this issue Jan 25, 2017
@nijel nijel Changelog entry for #12923
Signed-off-by: Michal Čihař <michal@cihar.com>
c18d2a9
@nijel nijel added this to the 4.7.0 milestone Jan 25, 2017
@domnulnopcea
Contributor

are we going to wait weeks for this to come into a new release?
I stress that this bug is present for a few months now...

@nijel
Member
nijel commented Jan 25, 2017

Unfortunately this problem appeared again due to different bug, I'm sorry about that, but bugs do happen. Unfortunately we don't have manpower to do rigorous QA tests prior to release or to write automated tests for all the features, but certainly any help in this area is welcome.

BTW: 4.7.0-beta1 with this fix will be probably out today. By using and testing the beta, you can provide us valuable feedback to avoid bugs appearing in the final release.

@ibennetch
Contributor
@domnulnopcea
Contributor
@ibennetch
Contributor

@domnulnopcea The release of version 4.7.0 is currently scheduled to occur towards the end of March.

@domnulnopcea
Contributor
@OlafvdSpek

The expected behavior is that If you enter any text in the filter-box, it automatically searches for the items on the page currently displayed in the navigation.

Why is that expected? I don't think it's what users expect.. it's simply what's easy to implement.

@nijel
Member
nijel commented Feb 13, 2017

And what do you think does user expect?

@domnulnopcea
Contributor

the user expects to search through all the available pages. this is a common pattern in all web applications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment