Sorting numbers properly #12941

Closed
OlafvdSpek opened this Issue Feb 1, 2017 · 6 comments

Projects

None yet

2 participants

@OlafvdSpek

The nav tree at the left sorts numbers properly but this dropdown doesn't.. could this be fixed?
3 < 31 ;)

pma

@nijel
Member
nijel commented Feb 2, 2017

Which dropdown is that? But indeed it should honor $cfg['NaturalOrder'].

@nijel nijel added the bug label Feb 2, 2017
@OlafvdSpek

One on the internal relations form.

@nijel nijel added this to the 4.7.0 milestone Feb 2, 2017
@nijel nijel added a commit that closed this issue Feb 2, 2017
@nijel nijel Fixed sorting of tables in relation view
Fixes #12941

Signed-off-by: Michal Čihař <michal@cihar.com>
5a3410c
@nijel nijel closed this in 5a3410c Feb 2, 2017
@nijel nijel self-assigned this Feb 2, 2017
@OlafvdSpek
OlafvdSpek commented Feb 2, 2017 edited

db_central_columns.php also has a tables dropdown, not sure what other pages have it.

And not sure whether I'm having a caching issue or whether this isn't fixed..
Shouldn't the fix be in internal_relational_row.phtml too?

@nijel nijel added a commit that referenced this issue Feb 2, 2017
@nijel nijel Fix more tables where table sorting is not honored
Issue #12941

Signed-off-by: Michal Čihař <michal@cihar.com>
4f15120
@nijel nijel added a commit that referenced this issue Feb 2, 2017
@nijel nijel Use getTables instead of contructing the list again
We do not need any condition here as in native relations.

Issue #12941

Signed-off-by: Michal Čihař <michal@cihar.com>
f67ac81
@nijel
Member
nijel commented Feb 2, 2017

I've noticed other places as well, should be fixed now.

@OlafvdSpek

Hmm: Missing argument 1 for PMA\libraries\DatabaseInterface::getTables(), called in /srv/pma/templates/table/relation/internal_relational_row.phtml on line 26 and defined

@nijel nijel added a commit that referenced this issue Feb 2, 2017
@nijel nijel Add missing parameter (issue #12941)
Signed-off-by: Michal Čihař <michal@cihar.com>
736e206
@OlafvdSpek

Doesn't appear to be fixed for tbl_relation.php yet.

pma

Git: 8765588

@nijel nijel reopened this Feb 9, 2017
@nijel nijel added a commit that closed this issue Feb 13, 2017
@nijel nijel Sort column names as well
Fixes #12941

Signed-off-by: Michal Čihař <michal@cihar.com>
522c059
@nijel nijel closed this in 522c059 Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment