Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't copy/paste from JS error pop up #12969

Closed
OlafvdSpek opened this issue Feb 8, 2017 · 11 comments · Fixed by #15865
Closed

Can't copy/paste from JS error pop up #12969

OlafvdSpek opened this issue Feb 8, 2017 · 11 comments · Fixed by #15865
Assignees
@williamdes
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Enhancements
Milestone
5.1.0

Comments

@OlafvdSpek
Copy link

The pop up disappears before I can do the copy operation.
@mynetx
Copy link
Contributor

mynetx commented Feb 10, 2017

Can you paste a photo here?

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Mar 13, 2017

Hello @OlafvdSpek steps to reproduce this error, with some photos thanks.

@nijel nijel added enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface labels Mar 21, 2017
@williamdes williamdes added this to Triage zone in Enhancements Jan 23, 2020
@williamdes
Copy link
Member

@OlafvdSpek 🏓

@williamdes
Copy link
Member

Are you talking about an error and you are trying to copy the query ?

@williamdes williamdes moved this from Triage zone to Interface in Enhancements Jan 24, 2020
@OlafvdSpek
Copy link
Author

I was trying to copy the error message.

@williamdes
Copy link
Member

williamdes commented Jan 24, 2020 •
edited

Okay, now someone will be able to work on this issue 👍

@williamdes williamdes moved this from Interface to Nice to have soon in Enhancements Jan 24, 2020
@yashrajbothra
Copy link
Contributor

yashrajbothra commented Jan 26, 2020 •
edited

image

When we click it gets dissmissed so there no room to copy.

IMO it should copy and dismiss on same click OR a icon on Top Right to copy? Any other suggestion ❔

@williamdes
Copy link
Member

Maybe adding more time if we detect that the user is copying the text would be an option

@yashrajbothra
Copy link
Contributor

Did you mean If user click-n-hold then stop and if its just a click then dismiss?

@OlafvdSpek
Copy link
Author

Maybe it shouldn't be a popup at all.. it could be a 'normal' message above the input field.

@yashrajbothra
Copy link
Contributor

Maybe it shouldn't be a popup at all.. it could be a 'normal' message above the input field.

Ya, but then it will be limited to input fields only 😕

yashrajbothra added a commit to yashrajbothra/phpmyadmin that referenced this issue Jan 27, 2020
@yashrajbothra
phpmyadmin#12969 added timer to hold dismissable class
50c4bc2 
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
@yashrajbothra yashrajbothra mentioned this issue Jan 27, 2020
Merged
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jan 27, 2020
@williamdes williamdes added this to the 5.1.0 milestone Jan 28, 2020
@williamdes williamdes self-assigned this Feb 23, 2020
williamdes added a commit that referenced this issue Feb 23, 2020
@williamdes
Add ChangeLog entry for #12969 and fix typo on previous entry
9e981f2 
Signed-off-by: William Desportes <williamdes@wdes.fr>
Enhancements automation moved this from Nice to have soon to Done Feb 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Enhancements
  
Done
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Feature: Tap and hold will not dismiss Error box yashrajbothra/phpmyadmin
6 participants
@nijel @OlafvdSpek @mynetx @williamdes @Fenn-CS @yashrajbothra