New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error popup #13023

Closed
OlafvdSpek opened this Issue Feb 20, 2017 · 15 comments

Comments

Projects
None yet
6 participants
@OlafvdSpek

OlafvdSpek commented Feb 20, 2017

It's too small, I can't properly read the query this way.
It's a popup.. why?
Can't it be shown as a flash message, at the top of the page? Then maybe we could also copy/paste stuff from it.

pma

@Fenn-CS

This comment has been minimized.

Contributor

Fenn-CS commented Mar 9, 2017

The error display does not seem to happen the way you explained. Or you picture illustrates can you give me a step by step method on how to reproduce your own view? thanks.

error

@Fenn-CS

This comment has been minimized.

Contributor

Fenn-CS commented Mar 9, 2017

Moreover copying is very possible with error modal, I am wondering paste will be.

@OlafvdSpek

This comment has been minimized.

OlafvdSpek commented Mar 9, 2017

I used the Insert (Row) page.

@Fenn-CS

This comment has been minimized.

Contributor

Fenn-CS commented Mar 9, 2017

Ok but then the version am using seems to do validation ones entries are made and the form does not submit with any errors. So I will appreciate a step strep procedure which can be used to reproduce your issue

@OlafvdSpek

This comment has been minimized.

OlafvdSpek commented Mar 9, 2017

What version are you using?

You should be able to make the error popup somewhere..

@Fenn-CS

This comment has been minimized.

Contributor

Fenn-CS commented Mar 9, 2017

Version information: 4.8.0-dev, latest stable version: 4.6.6

@poush

This comment has been minimized.

Contributor

poush commented Mar 12, 2017

@OlafvdSpek I think I can make it some changes on the layout of this box or maybe we can shift it as toast message!

A quick change on box gives me
screen shot 2017-03-12 at 1 14 26 pm

Any suggestions ?

@OlafvdSpek

This comment has been minimized.

OlafvdSpek commented Mar 12, 2017

Looks better already.
A toast message would be even better.

@poush

This comment has been minimized.

Contributor

poush commented Mar 14, 2017

screenflow

@poush

This comment has been minimized.

Contributor

poush commented Mar 14, 2017

made an attempt to create small popup/message can be automatically dismissable

@Fenn-CS

This comment has been minimized.

Contributor

Fenn-CS commented Mar 15, 2017

@poush great work there! Please help me with a step by step method to reproduce the error pop up.

@nulll-pointer

This comment has been minimized.

Contributor

nulll-pointer commented Jun 27, 2018

@OlafvdSpek. I'm currently working on this, do you think showing it as a flash message will make it more readable? In my opinion, increasing the size of the box(and the query) and adding a copy query button would be better

@OlafvdSpek

This comment has been minimized.

OlafvdSpek commented Jun 27, 2018

A flash message would cause the error to remain visible while still allowing you to properly read / use the rest of the page, right? I think that's best.

@nulll-pointer

This comment has been minimized.

Contributor

nulll-pointer commented Jun 27, 2018

I was thinking about showing all kinds of error messages like the screenshot by @Fenn-CS. It will make the rest of the page accessible, and I'll add a copy query button as well. What about wrapping the query instead of scrolling it when it overflows.
@ibennetch

@OlafvdSpek

This comment has been minimized.

OlafvdSpek commented Jun 27, 2018

Looks reasonable.

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Jun 28, 2018

Adds features discussed in phpmyadmin#13023
1. Show ajax errors at the bottom of the page, instead of showing them in a popup.
2. Add copy query button for errors in processing sql queries.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

@nulll-pointer nulll-pointer referenced this issue Jun 28, 2018

Closed

Adds features discussed in #13023 #14436

0 of 4 tasks complete

mauriciofauth added a commit that referenced this issue Nov 15, 2018

Adds features discussed in #13023
1. Show ajax errors at the bottom of the page, instead of showing them in a popup.
2. Add copy query button for errors in processing sql queries.

Signed-off-by: Lakshay arora <arora.lakshya123@gmail.com>

@mauriciofauth mauriciofauth self-assigned this Nov 15, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Nov 15, 2018

mauriciofauth added a commit that referenced this issue Nov 15, 2018

Add ChangeLog entry for #13023
[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment