Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error popup #13023

Closed
OlafvdSpek opened this issue Feb 20, 2017 · 15 comments
Closed

Error popup #13023

OlafvdSpek opened this issue Feb 20, 2017 · 15 comments
Assignees
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Milestone

Comments

@OlafvdSpek
Copy link

It's too small, I can't properly read the query this way.
It's a popup.. why?
Can't it be shown as a flash message, at the top of the page? Then maybe we could also copy/paste stuff from it.

pma

@nijel nijel added enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface labels Mar 1, 2017
@Fenn-CS
Copy link
Contributor

Fenn-CS commented Mar 9, 2017

The error display does not seem to happen the way you explained. Or you picture illustrates can you give me a step by step method on how to reproduce your own view? thanks.

error

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Mar 9, 2017

Moreover copying is very possible with error modal, I am wondering paste will be.

@OlafvdSpek
Copy link
Author

I used the Insert (Row) page.

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Mar 9, 2017

Ok but then the version am using seems to do validation ones entries are made and the form does not submit with any errors. So I will appreciate a step strep procedure which can be used to reproduce your issue

@OlafvdSpek
Copy link
Author

What version are you using?

You should be able to make the error popup somewhere..

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Mar 9, 2017

Version information: 4.8.0-dev, latest stable version: 4.6.6

@poush
Copy link
Contributor

poush commented Mar 12, 2017

@OlafvdSpek I think I can make it some changes on the layout of this box or maybe we can shift it as toast message!

A quick change on box gives me
screen shot 2017-03-12 at 1 14 26 pm

Any suggestions ?

@OlafvdSpek
Copy link
Author

OlafvdSpek commented Mar 12, 2017

Looks better already.
A toast message would be even better.

@poush
Copy link
Contributor

poush commented Mar 14, 2017

screenflow

@poush
Copy link
Contributor

poush commented Mar 14, 2017

made an attempt to create small popup/message can be automatically dismissable

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Mar 15, 2017

@poush great work there! Please help me with a step by step method to reproduce the error pop up.

@aroralakshya
Copy link
Contributor

aroralakshya commented Jun 27, 2018

@OlafvdSpek. I'm currently working on this, do you think showing it as a flash message will make it more readable? In my opinion, increasing the size of the box(and the query) and adding a copy query button would be better

@OlafvdSpek
Copy link
Author

A flash message would cause the error to remain visible while still allowing you to properly read / use the rest of the page, right? I think that's best.

@aroralakshya
Copy link
Contributor

aroralakshya commented Jun 27, 2018

I was thinking about showing all kinds of error messages like the screenshot by @Fenn-CS. It will make the rest of the page accessible, and I'll add a copy query button as well. What about wrapping the query instead of scrolling it when it overflows.
@ibennetch

@OlafvdSpek
Copy link
Author

Looks reasonable.

@MauricioFauth MauricioFauth added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Oct 23, 2018
MauricioFauth pushed a commit that referenced this issue Nov 15, 2018
1. Show ajax errors at the bottom of the page, instead of showing them in a popup.
2. Add copy query button for errors in processing sql queries.

Signed-off-by: Lakshay arora <arora.lakshya123@gmail.com>
@MauricioFauth MauricioFauth self-assigned this Nov 15, 2018
@MauricioFauth MauricioFauth added this to the 5.0.0 milestone Nov 15, 2018
MauricioFauth added a commit that referenced this issue Nov 15, 2018
[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants