New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency with submit buttons #13067
Comments
|
Hello @ibennetch I suggest we start placing all the "Go" buttons on the right. Its more conventional that way, what do you think? |
|
I don't like right, when the window is wide it's a big distance between the content and the buttons.. |
|
What about putting into the middle? @ibennetch |
|
Ok then we should have a common base so someone can start working on this soon. Right is being discarded by @OlafvdSpek and middle proposed by @Progyan1997. So we are left with the options of left and middle. A quick conclusion will lead to solution of the problem |
|
I agree that the right side is generally more conventional, and I also agree that left side is closer, especially with a larger screen resolution. I doubt we'll get quick resolution on this issue simply because 'master' is currently targeting phpMyAdmin 4.8 and I feel this UI change should be made for 5.0. |
|
@ibennetch so it are we considering right? and which branch are we looking at here? |
|
It would eventually be for master. We don't usually deal with such
long-term changes, so there isn't really a policy about working in a
"future" or (5.0) branch or something, although I suppose that would be
possible.
For now, I would say this is not a good project for a GSoC applicant to
work on.
|
|
Ok @ibennetch thanks for your tremendous support. |
|
For now, what if we put the keyboard shortcut such like "ctrl+enter" for go button. |
|
Is anyone working on this, I am a newbie to open source and would like to contribute. |
|
Me too! I am new to open source I am lost reading the thread. I'd like to contribute. |
|
@bahl24 and @cornzie welcome! We love new contributors. No one is currently working on this, so @bahl24 feel free to jump in and submit a pull request. If you get stuck or would like some advice, we have the developers mailing list and a Gitter room which are both good places to ask general questions. If you're familiar with Git, that will help, but it's pretty easy and we have some hints on our wiki (https://github.com/phpmyadmin/phpmyadmin/wiki/Developer_guidelines and https://github.com/phpmyadmin/phpmyadmin/wiki/Git). @cornzie What sort of help would you like to give? We'd love to have you involved. Is your interest in coding, testing, or writing documentation? We have a lot of bug reports that need to be confirmed, the documentation (and wiki, too) need to be continually updated, and other things. Of course we love code contributions, too. |
[CI skip] Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
We have inconsistent behavior with how submit buttons are placed; sometimes "Go" is on the far left, such as on the Insert tab; other times "Go" is on the far right, as on the page for adding rows to a table.
I think we should pick a standard and make the change to make the whole interface consistent in some future version (probably 5.0).
The text was updated successfully, but these errors were encountered: