Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency with submit buttons #13067

Closed
ibennetch opened this issue Mar 12, 2017 · 12 comments · Fixed by #14680
Closed

Inconsistency with submit buttons #13067

ibennetch opened this issue Mar 12, 2017 · 12 comments · Fixed by #14680
Assignees
Labels
enhancement A feature request for improving phpMyAdmin hacktoberfest has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted newbie ui Issues relating to the user interface
Milestone

Comments

@ibennetch
Copy link
Member

We have inconsistent behavior with how submit buttons are placed; sometimes "Go" is on the far left, such as on the Insert tab; other times "Go" is on the far right, as on the page for adding rows to a table.

I think we should pick a standard and make the change to make the whole interface consistent in some future version (probably 5.0).

@nijel nijel added enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface labels Mar 13, 2017
@Fenn-CS
Copy link
Contributor

Fenn-CS commented Mar 13, 2017

Hello @ibennetch I suggest we start placing all the "Go" buttons on the right. Its more conventional that way, what do you think?

@OlafvdSpek
Copy link

I don't like right, when the window is wide it's a big distance between the content and the buttons..

@0xTheProDev
Copy link
Contributor

What about putting into the middle? @ibennetch

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Mar 15, 2017

Ok then we should have a common base so someone can start working on this soon. Right is being discarded by @OlafvdSpek and middle proposed by @Progyan1997. So we are left with the options of left and middle. A quick conclusion will lead to solution of the problem

@ibennetch
Copy link
Member Author

I agree that the right side is generally more conventional, and I also agree that left side is closer, especially with a larger screen resolution.

I doubt we'll get quick resolution on this issue simply because 'master' is currently targeting phpMyAdmin 4.8 and I feel this UI change should be made for 5.0.

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Mar 15, 2017

@ibennetch so it are we considering right? and which branch are we looking at here?

@ibennetch
Copy link
Member Author

ibennetch commented Mar 15, 2017 via email

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Mar 15, 2017

Ok @ibennetch thanks for your tremendous support.

@akshilshah
Copy link

For now, what if we put the keyboard shortcut such like "ctrl+enter" for go button.

@bahl24
Copy link
Contributor

bahl24 commented Jun 30, 2018

Is anyone working on this, I am a newbie to open source and would like to contribute.

@cornzie
Copy link

cornzie commented Jul 1, 2018

Me too! I am new to open source I am lost reading the thread. I'd like to contribute.

@ibennetch
Copy link
Member Author

@bahl24 and @cornzie welcome! We love new contributors.

No one is currently working on this, so @bahl24 feel free to jump in and submit a pull request. If you get stuck or would like some advice, we have the developers mailing list and a Gitter room which are both good places to ask general questions. If you're familiar with Git, that will help, but it's pretty easy and we have some hints on our wiki (https://github.com/phpmyadmin/phpmyadmin/wiki/Developer_guidelines and https://github.com/phpmyadmin/phpmyadmin/wiki/Git).

@cornzie What sort of help would you like to give? We'd love to have you involved. Is your interest in coding, testing, or writing documentation? We have a lot of bug reports that need to be confirmed, the documentation (and wiki, too) need to be continually updated, and other things. Of course we love code contributions, too.

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Oct 19, 2018
@MauricioFauth MauricioFauth self-assigned this Nov 3, 2018
MauricioFauth added a commit that referenced this issue Nov 3, 2018
[CI skip]

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement A feature request for improving phpMyAdmin hacktoberfest has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted newbie ui Issues relating to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants