Table SQL: Align Query and Columns fields

[OlafvdSpek]

Could the Columns field be extended downward to consume the empty space?

[nijel]

Certainly they could be sized same as the textarea.

[Achilles-96]

This is how I have it.

I checked it on demo server as well. It is similar.

[OlafvdSpek]

Could the difference be due to $cfg['CodemirrorEnable'] = false; ?

[nijel]

Yes, the default dimensions are different. Also as the editing area is resizeable, the height of columns selector should match it even when resizing.

[OlafvdSpek]

Should the default size be different?

[nijel]

That's probably just a side effect of different fonts, the number of rows should be same and should match $cfg['TextareaRows'].

[Fenn-CS]

Thats the reason why the pages have to be responsive to avoid such errors caused by user preferences and browsers like in this case fonts.

[JSn1nj4]

Hi, is there still room to jump in on this? I'd like to start contributing.

[KasperFranz]

Is this not already implemented - when I just tried to open this it looked like it was correct

[williamdes]

@JSn1nj4 Are you still interested in contributing ?

[willwalsh96]

I want to try this issue. How do I see how my changes affect the running application? I do not want to host my own server to do testing.

[williamdes]

@willwalsh96 you could do the changes online and submit a patch afterwards
For sure having a local php web server would be a better idea
Demo servers (root, no password)

• 5.1.0-dev
• 5.0.x-dev
• 4.9.x

[JSn1nj4]

@williamdes I'm sorry, I was, but I'm too short on time to add a project into my schedule. Sorry for the late reply.

[ri5h]

@willwalsh96 Is this issue still valid? I want to work on it if possible. Seems valid in the demo server.

[williamdes]

@rishirajpurohit Is seems still valid, you can have a try to fix it if you want

[ri5h]

@williamdes 👍 Awesome, on it. The expected behaviour is have the same height by default. Quick questions:

1. If user resizes the Query field, should it change the height of column field as well ?
2. Should the target be master ?

[williamdes]

@williamdes Awesome, on it. The expected behaviour is have the same height by default. Quick questions:

1. If user resizes the Query field, should it change the height of column field as well ?
2. Should the target be master ?

@OlafvdSpek what do you think about this ?

I would like to have the text area in sync with the column list

Should the target be master ?

Yes

[OlafvdSpek]

Yes, having the two fields be the same vertical size seems good.