New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Alive Error? #13183

Closed
OlafvdSpek opened this Issue Apr 12, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@OlafvdSpek

OlafvdSpek commented Apr 12, 2017

I think this is a keep-alive request failing (due to WiFi being down). The error message isn't clear at all and shouldn't this error just be ignored?

pma

@udan11

This comment has been minimized.

Show comment
Hide comment
@udan11

udan11 Apr 12, 2017

Member

Would something like "Error in contacting the server" be more helpful?

Member

udan11 commented Apr 12, 2017

Would something like "Error in contacting the server" be more helpful?

@OlafvdSpek

This comment has been minimized.

Show comment
Hide comment
@OlafvdSpek

OlafvdSpek Apr 12, 2017

No. I'm not sure what the actual cause is, I think it shouldn't error out at all.

OlafvdSpek commented Apr 12, 2017

No. I'm not sure what the actual cause is, I think it shouldn't error out at all.

@udan11

This comment has been minimized.

Show comment
Hide comment
@udan11

udan11 Apr 12, 2017

Member

You mentioned that WiFi was down and I thought the server is not local.

Member

udan11 commented Apr 12, 2017

You mentioned that WiFi was down and I thought the server is not local.

@udan11 udan11 added bug and removed enhancement newbie labels Apr 14, 2017

@OlafvdSpek

This comment has been minimized.

Show comment
Hide comment
@OlafvdSpek

OlafvdSpek commented Apr 19, 2017

It's not.

@nijel nijel self-assigned this Sep 4, 2017

@nijel nijel added this to the 4.7.5 milestone Sep 4, 2017

nijel added a commit that referenced this issue Sep 4, 2017

Include error detail in the error message
Issue #13183

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Sep 4, 2017

Do not include error code 0 in the message
It really is not useful information.

Issue #13183

Signed-off-by: Michal Čihař <michal@cihar.com>

@nijel nijel closed this in 04add7c Sep 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment