Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created procedure (using side-column) shows up in triggers... #13325

Closed
claskfosmic opened this issue May 30, 2017 · 14 comments · Fixed by #16652
Closed

Created procedure (using side-column) shows up in triggers... #13325

claskfosmic opened this issue May 30, 2017 · 14 comments · Fixed by #16652
Assignees
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
Milestone

Comments

@claskfosmic
Copy link

claskfosmic commented May 30, 2017

Steps to reproduce

  1. Create a new database with a table with a trigger on it. Also, create a procedure for the database.
CREATE TABLE `Table_03` (
  `id` int(11) NOT NULL,
  `valueA` int(11) NOT NULL DEFAULT '0',
  `valueB` int(11) NOT NULL DEFAULT '0',
  `sum` int(11) NOT NULL DEFAULT '0'
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;


DELIMITER $$
CREATE TRIGGER `trigger_03` BEFORE UPDATE ON `Table_03` FOR EACH ROW SET NEW.`sum` = NEW.`valueA`+NEW.`valueB`
$$
DELIMITER ;

ALTER TABLE `Table_03` ADD PRIMARY KEY (`id`);

DELIMITER $$

CREATE DEFINER=`root`@`localhost` PROCEDURE `test_01` (IN `foo` INT(11), OUT `bar` INT(11))  NO SQL
SET bar = foo$$

DELIMITER ;
  1. After creating, everything will be shown in phpMyAdmin. When going the tab 'Triggers', the page will look something like this:

image

  1. Now, use the 'New' button (see image above, red squared), from the side menu to create a new procedure... It doesn't matter what the procedure does... Just create someting.

  2. After clicking the 'Go' button in the modal-popup, the created procedure will be shown in the list with triggers:

image

Expected behaviour

The created procedure should not appear in the list with triggers.

Actual behaviour

The created procedure appears in the list with triggers, however, it doesn't belong here.

Server configuration

Operating system: Ubuntu 15.10 (GNU/Linux 4.2.0-16-generic x86_64)

Web server: Apache/2.4.12 (Ubuntu)

Database: 5.7.12-1exp1+deb.sury.orgwily+1 - (Ubuntu)

PHP version: 7.1.0-dev

phpMyAdmin version: 4.7.1

Client configuration

Browser: Google Chrome 58.0.3029.110 (64-bit)

Operating system: Windows 10 Pro Build 10586.916

@williamdes
Copy link
Member

Confirmed on phpMyAdmin 5.0.0-dev
selection_041

@williamdes williamdes added the Bug A problem or regression with an existing feature label Oct 27, 2018
@williamdes williamdes added this to to be fixed soon in issues Apr 29, 2019
@williamdes
Copy link
Member

@vibhuti019 could you fix this one?

@vibhuti019
Copy link

vibhuti019 commented Feb 16, 2020

It may require some help. I can try @williamdes.

@vibhuti019
Copy link

Can you guide me on how to remove this bug?

@williamdes
Copy link
Member

@vibhuti019 did you reproduce this issue on your local setup ?
@kartik1000 could you please help on this one ?

@kartik1000
Copy link
Contributor

@williamdes I will reproduce and let you know.

@vibhuti019
Copy link

vibhuti019 commented Feb 20, 2020

Screenshot from 2020-02-20 09-35-39

Yes, @williamdes. I have reproduced this issue.
But, it gets removed once I refresh the page.

Screenshot from 2020-02-20 09-55-18

@williamdes
Copy link
Member

Screenshot from 2020-02-20 09-35-39

Yes, @williamdes. I have reproduced this issue.
But, it gets removed once I refresh the page.

Screenshot from 2020-02-20 09-55-18

It gets moved to the right section ;)
Now you need to discover what makes it go into the wrong section (triggers/functions)

Do you need further help?

@vibhuti019
Copy link

vibhuti019 commented Feb 27, 2020

Not just with the procedure.
But this issue is with all functions which create a new entry (except Indexes).

Screenshot from 2020-02-27 05-57-27
Like, in this case, I have generated a trigger while I am in the Procedure tab.

Screenshot from 2020-02-27 06-06-59
And in this case, I have created a trigger while viewing the list of Databases.

The problem could be due to the JavaScript function which updates the table.
I could not find that function.
Please guide me.

@shucon
Copy link
Contributor

shucon commented Feb 12, 2021

Working on this!

@shucon
Copy link
Contributor

shucon commented Feb 13, 2021

Hey @williamdes , I'm unable to reproduce this issue on the current master.

@williamdes
Copy link
Member

Reproduced by following the initial steps
image

https://phpmyadmin-pr-16640.wdes.eu.org/ (root/public public/public)

@shucon
Copy link
Contributor

shucon commented Feb 14, 2021

Got it! I wasn't opening the Triggers page before adding the procedure. Will try to fix this.

@williamdes
Copy link
Member

Confirmed on QA_5_1 demo server
image

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Feb 17, 2021
@williamdes williamdes added this to the 5.1.1 milestone Feb 25, 2021
williamdes added a commit that referenced this issue Feb 25, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from to be fixed soon to Closed Feb 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Development

Successfully merging a pull request may close this issue.

5 participants