New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct location information for locales from Twig templates #13344

Closed
nijel opened this Issue Jun 1, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@nijel
Member

nijel commented Jun 1, 2017

We currently only fix the filename in the scripts/update-po script, but the location could be fixed as well using getDebugInfo method.

See also 9d1b49a#commitcomment-22308597

@nijel nijel added the enhancement label Jun 1, 2017

nijel referenced this issue Jun 1, 2017

Improve extracting translatable strings from Twig templates
- use separate (clean) directory to avoid messing up with stale cache
  data or other files in the temporary dir
- restore filenames for twig templates in Gettext files, the lines still
  don't match, but at least the filename is correct
- extract the _gettext function as well

Signed-off-by: Michal Čihař <michal@cihar.com>

@nijel nijel self-assigned this Nov 2, 2017

@nijel nijel added this to the 4.8.0 milestone Nov 2, 2017

@nijel nijel closed this in 5a2a115 Nov 2, 2017

nijel added a commit that referenced this issue Nov 2, 2017

Use php for fixing line information in the Gettext files
The debug information actually maps ranges, not individual lines, so it
needs more logic.

Also the sed was really slow (as it had to replace all lines).

Issue #13344

Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment