Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use spaces in table names in CSV import #13424

Closed
OlafvdSpek opened this issue Jun 30, 2017 · 7 comments · Fixed by #14935
Closed

Don't use spaces in table names in CSV import #13424

OlafvdSpek opened this issue Jun 30, 2017 · 7 comments · Fixed by #14935
Assignees
@MauricioFauth
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Milestone
5.0.0

Comments

@OlafvdSpek
Copy link

Importing a CSV created tables named "Table ##" with ## being a number. Spaces in table names are annoying, could you drop the space or replace it by an underscore?

Even better, have a table name field in the form and default it to the base file name.
@ibennetch
Copy link
Member

ibennetch commented Jul 1, 2017 via email

@nijel nijel added the enhancement A feature request for improving phpMyAdmin label Jul 18, 2017
amarjitsingh52922 added a commit to amarjitsingh52922/phpmyadmin that referenced this issue Feb 6, 2019
@amarjitsingh52922
Fix for phpmyadmin#13424 Importing a CSV created tables named "Table ##"
2537ac7 
Signed-off-by: Amarjit Singh <amarjitsingh52922@gmail.com>
@amarjitsingh52922 amarjitsingh52922 mentioned this issue Feb 6, 2019
Merged
6 tasks
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Feb 6, 2019
@amarjitsingh52922
Copy link
Contributor

@williamdes i made the code and tested on my local phpmyadmin it works like a charm
but has few doubts regarding PR. in PR template there are some options to choose with square brackets

so for them i have to put x in them like [x] or let it as it is

pl guide as i am new to github but too good in PHP/jquery

@williamdes
Copy link
Member

@amarjitsingh52922 I will review the PR soon :)

@amarjitsingh52922
Copy link
Contributor

amarjitsingh52922 commented Feb 8, 2019 •
edited

@williamdes thanks but i also need direction to do more PR as going to tackle some some more issues/enhancements

@williamdes
Copy link
Member

williamdes commented Feb 8, 2019 •
edited

@amarjitsingh52922 Can you join Slack or Gitter, so I can help you :)

@amarjitsingh52922
Copy link
Contributor

amarjitsingh52922 commented Feb 9, 2019 via email •
edited by williamdes

@williamdes
Copy link
Member

@amarjitsingh52922 Here is a new link :)

amarjitsingh52922 added a commit to amarjitsingh52922/phpmyadmin that referenced this issue Feb 10, 2019
@amarjitsingh52922
Fix for phpmyadmin#13424 Importing a CSV created tables named Table ##
46d127a 
Signed-off-by: amarjitaa <amarjitsingh52922@gmail.com>
amarjitsingh52922 added a commit to amarjitsingh52922/phpmyadmin that referenced this issue Feb 10, 2019
@amarjitsingh52922
Fix for phpmyadmin#13424 Importing a CSV created tables named Table ##
8a6f485 
Signed-off-by: amarjitaa <amarjitsingh52922@gmail.com>
amarjitsingh52922 added a commit to amarjitsingh52922/phpmyadmin that referenced this issue Feb 10, 2019
@amarjitsingh52922
Fix for phpmyadmin#13424 Importing a CSV created tables named Table ##
d35417c 
Signed-off-by: amarjitaa <amarjitsingh52922@gmail.com>
amarjitsingh52922 added a commit to amarjitsingh52922/phpmyadmin that referenced this issue Feb 10, 2019
@amarjitsingh52922
Fix for phpmyadmin#13424 Importing a CSV created tables named Table ##
0293b19 
Signed-off-by: amarjitaa <amarjitsingh52922@gmail.com>
amarjitsingh52922 added a commit to amarjitsingh52922/phpmyadmin that referenced this issue Feb 10, 2019
@amarjitsingh52922
Fix for phpmyadmin#13424 Importing a CSV created tables named Table ##
04e591a 
Signed-off-by: amarjitaa <amarjitsingh52922@gmail.com>
amarjitsingh52922 added a commit to amarjitsingh52922/phpmyadmin that referenced this issue Feb 10, 2019
@amarjitsingh52922
Fix for phpmyadmin#13424 Importing a CSV created tables named Table ##"
6ffe1ac 
phpmyadmin#14935

Signed-off-by: amarjitaa <amarjitsingh52922@gmail.com>
amarjitsingh52922 added a commit to amarjitsingh52922/phpmyadmin that referenced this issue Feb 10, 2019
@amarjitsingh52922
Fix for phpmyadmin#13424 Importing a CSV created tables named Table ##"
660edae 
phpmyadmin#14935

Signed-off-by: amarjitaa <amarjitsingh52922@gmail.com>
amarjitsingh52922 added a commit to amarjitsingh52922/phpmyadmin that referenced this issue Feb 10, 2019
@amarjitsingh52922
Fix for phpmyadmin#13424 Importing a CSV created tables named Table ##"
153e6c3 
phpmyadmin#14935

Signed-off-by: amarjitaa <amarjitsingh52922@gmail.com>
MauricioFauth pushed a commit that referenced this issue Mar 25, 2019
@amarjitsingh52922 @MauricioFauth
Fix for #13424 Importing a CSV created tables named Table ##" (#14935)
dd88475 
Fix #13424 Importing a CSV created tables named "Table ##"

Signed-off-by: Amarjit Singh <amarjitsingh52922@gmail.com>
@MauricioFauth MauricioFauth self-assigned this Mar 25, 2019
@MauricioFauth MauricioFauth added this to the 5.0.0 milestone Mar 25, 2019
MauricioFauth added a commit that referenced this issue Mar 25, 2019
@MauricioFauth
Add ChangeLog entry for #13424
be936ac 
Fix coding standard errors

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MauricioFauth MauricioFauth

Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Fix for #13424 Importing a CSV created tables named Table ##" amarjitsingh52922/phpmyadmin
6 participants
@MauricioFauth @nijel @ibennetch @OlafvdSpek @williamdes @amarjitsingh52922