New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table zoom page errors #13439

Closed
manishbisht opened this Issue Jul 3, 2017 · 0 comments

Comments

Projects
None yet
3 participants
@manishbisht
Contributor

manishbisht commented Jul 3, 2017

Steps to reproduce

  1. Open table zoom select page.
  2. Do any operation to perform the zoom search.
  3. It shows errors.

Expected behaviour

Should run without errors.

Actual behaviour

Shows errors

screenshot from 2017-07-03 23-13-21

@nijel nijel added the bug label Jul 18, 2017

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Feb 14, 2018

Fix for issue phpmyadmin#13439
Changed
./templates/table/search/rows_zoom.twig
./js/tbl_zoom_plot_jqplot.js
Problem 1:
Due to insuffiecent number of td elements in a tr in zoom search form table, the type field was not getting passed. Added a <td> element in zoom search table.
Problem 2:
The event handlers attached on #tableid_{} elements were inserting values in wrong tr elements.

Signed-Off-By: Lakshay arora(b16060@students.iitmandi.ac.in)

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Feb 14, 2018

Fix for issue phpmyadmin#13439
Problem 1:
The number of td elements in the zoom search form table were insufficient, due to which, the field_type(element #types_$) was getting replaced with field_value(element td:eq(3))(see ./js/tbl_zoom_jqplot.js lines 164, 188, 211, 232). Added a td element in the table for each row.
Problem 2:
The events attached to 'tableid_$' were inserting the values in wrong tr elements(see ./js/tbl_zoom_jqplot.js lines 185-188, 208-211, 229-232), leading to wrong values being passed to the zoom search.

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Feb 14, 2018

Fix for issue phpmyadmin#13439
Problem 1:
The number of td elements in the zoom search form table were insufficient, due to which, the field_type(element #types_$) was getting replaced with field_value(element td:eq(3))(see ./js/tbl_zoom_jqplot.js lines 164, 188, 211, 232). Added a td element in the table for each row.
Problem 2:
The events attached to 'tableid_$' were inserting the values in wrong tr elements(see ./js/tbl_zoom_jqplot.js lines 185-188, 208-211, 229-232), leading to wrong values being passed to the zoom search.
Signed-Off-By: Lakshay arora(b16060@students.iitmandi.ac.in)

mauriciofauth added a commit that referenced this issue Mar 29, 2018

Fix for issue #13439
Problem 1:
The number of td elements in the zoom search form table were insufficient, due to which, the field_type(element #types_$) was getting replaced with field_value(element td:eq(3))(see ./js/tbl_zoom_jqplot.js lines 164, 188, 211, 232). Added a td element in the table for each row.
Problem 2:
The events attached to 'tableid_$' were inserting the values in wrong tr elements(see ./js/tbl_zoom_jqplot.js lines 185-188, 208-211, 229-232), leading to wrong values being passed to the zoom search.

Signed-off-by: Lakshay arora <b16060@students.iitmandi.ac.in>

@mauriciofauth mauriciofauth self-assigned this Mar 29, 2018

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment