Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Select only visible / filtered results #13517
Steps to reproduce
After results are filtered, only visible / filtered results should be selected, which affects any operation from the "With selected" links, like "Edit" and "Delete" (it would be nice to have these links appear at the top as well).
All results get selected instead, even those that are hidden !
Operating system: Windows 7 x64
Web server: Apache 2.4.26
Database: MariaDB version 10.2.6
PHP version: 7.1.7
phpMyAdmin version: 4.7.2
Indeed current situation is not intuitive, but when touching this, the behavior should be probably consistently applied in all cases - the very same applies to database structure and tables filtering.
Also it should probably behave consistently in other direction as well: Once you select all and apply filter, only filtered rows should be probably affected.
In fact, it has nothing to do with the logic behind actions like updating or deleting rows, as those are handled separately after the action is requested (based on the selected checkboxes).
the other direction is a bit tricky, because it depends on whether the "Check All" is active or not :
This BUG actually also affects the database table view as well. If you filter by table view, and use "check all", it selects the hidden tables as well. If you select drop, it will now delete all of the filtered AND unfiltered tables as well (found this bug by accident... wiped out 30+ tables instead of the 15 I though I had filtered/selected).
It should be noted that if you manually check each item in the view, it will only affect those items actually marked (so manually selecting the entire visible list is not affected by the same logic).