Add index has no Preview SQL

[OlafvdSpek]

The Add Index popup has no Preview SQL button.

[KeerthanaRatna]

Hi ,
There is a Preview SQL button in the Add Index popup when adding a index to a already existing column.

But there is no Preview SQL button when adding a index during table creation and column addition.

[aroralakshya]

What is the need for a separate previewsql to view the index when there is one to view the whole query??

[williamdes]

@OlafvdSpek For me this is already implemented

[OlafvdSpek]

[williamdes]

Okay, on a new table.
That was a missing detail !

[OlafvdSpek]

Was mentioned in #13519 (comment) two years ago.

[williamdes]

Right, reading the message stops the eye to the picture.
I hope somebody will pick this one and solve it.

[thesmallstar]

Can I work on this?

[williamdes]

@thesmallstar yes, go ahead

please use master branch

[thesmallstar]

@williamdes I tried searching for the solution, The previewSql is present(in code) but it doesn't appear in the frontend. Probably the innerHTML is being replaced. Can you help me with how to proceed?

[williamdes]

@thesmallstar are you looking for Functions.highlightSql($('#page_content')); ?

[thesmallstar]

no, I have found the line that is causing this problem.
line 409, indexes.js
// We dont need the slider at this moment. $(this).find('fieldset.tblFooters').remove();

If I remove this,

something like this would appear.

I could remove the duplicate Go button, and it looks like this.

I guess this was hidden since the dialogue box came with its own footer and go and cancel button, should I try to add previewSql button for this particular one?
I think it is hidden for some reason, but not sure why,

[williamdes]

I could remove the duplicate Go button, and it looks like this.

Okay, I agree to remove it
If you search in the history I am quite sure to have merged a PR to remove duplicate Go buttons

I guess this was hidden since the dialogue box came with its own footer and go and cancel button, should I try to add previewSql button for this particular one?
I think it is hidden for some reason, but not sure why,

We can add it back and see what happens, anyways it is the development version :)

[OlafvdSpek]

We can add it back and see what happens, anyways it is the development version :)

What is that supposed to mean? ;)

[williamdes]

We can add it back and see what happens, anyways it is the development version :)

What is that supposed to mean? ;)

That we have a very long review time before a release is done
So if something is not perfect or has side effects a solution can be found ;)

[MauricioFauth]

We can add it back and see what happens, anyways it is the development version :)

What is that supposed to mean? ;)

That we have a very long review time before a release is done
So if something is not perfect or has side effects a solution can be found ;)

Makes sense, however we should pay attention to this because it's very easy to something temporary become permanent.

[OlafvdSpek]

IMO the goal should be for the main dev branch to be production quality / release ready at all times.
Ensure an update is correct before merging it, rather then fixing it after merging.

[williamdes]

Makes sense, however we should pay attention to this because it's very easy to something temporary become permanent.

True

IMO the goal should be for the main dev branch to be production quality / release ready at all times.
Ensure an update is correct before merging it, rather then fixing it after merging.

I agree, I try to have everything right and clean before merging.
But I would needs more reviewers to be 100% sure nothing escaped my attention

[thesmallstar]

Quite a few things to learn from this discussion :P
@williamdes I will proceed with the proposed solution.