Use a full list of functions on insert/edit page "Function" select

[OlafvdSpek]

The list appears to be split into two, not sure on what criteria..

I think it'd be easier if it was a single list.

[nijel]

The functions are grouped by types, first list showing functions which apply to current type.

[nijel]

We can improve this by adding additional group labels to the list, that should make it clear why the list is split.

[ibennetch]

Optgroup labels like "Suggested" and "All" or something similar.

[OlafvdSpek]

The trouble with split lists is that one has to figure out in what list a function is.
If I'm looking for unix_timestamp I already know it's near the bottom (normally)..

[ibennetch]

Indeed, but my solution to that would be to put all functions below the separation, so some are in the list twice (once as a suggested function and again further below)

[OlafvdSpek]

Then you're in the same situation as I'm now: we've got U, we've got V, but no unix_timestamp.. and then: oh, wait, it's in the second part of the list.

[nijel]

That's true. On the other side, it probably doesn't make sense to show functions returning string when working with numeric fields. The current solution was chosen probably to allow using functions even in case the categorization would be bad.

So are there any particular functions you were missing in the first list for some fields?

[OlafvdSpek]

I think it was unix_timestamp(), it's not in the screenshot but it's in the list now.
IMO having a single list, probably without filtering, would be so much simpler.

[rabeehrz]

@williamdes I would like to work on this.
If I'm correct, I just have to remove the seperator and make everything a single list right?

[williamdes]

I am not sure about what to do :)
Please ping me back on this one Saturday

[rabeehrz]

@williamdes ping.

[williamdes]

phpmyadmin/libraries/classes/Util.php

Lines 3921 to 3935 in 6729c89

	$functions = $GLOBALS['dbi']->types->getFunctions($field['True_Type']);
	foreach ($functions as $function) {
	$retval .= '<option';
	if (isset($foreignData['foreign_link']) && $foreignData['foreign_link'] !== false && $default_function === $function) {
	$retval .= ' selected="selected"';
	}
	$retval .= '>' . $function . '</option>' . "\n";
	$dropdown_built[$function] = true;
	}
	// Create separator before all functions list
	if (count($functions) > 0) {
	$retval .= '<option value="" disabled="disabled">--------</option>'
	. "\n";
	}

The criteria is to list functions for the column type

Maybe we can add a configuration option, or remove the first group of entries

[rabeehrz]

@williamdes I've already made the changes. I'll open up a PR?

[rabeehrz]

@williamdes I found another set of code here as well.

phpmyadmin/libraries/classes/Html/Generator.php

Lines 550 to 568 in f4c7796

	public static function getFunctionsForField(array $field, $insert_mode, array $foreignData): string
	{
	$default_function = self::getDefaultFunctionForField($field, $insert_mode);
	$dropdown_built = [];
	// Create the output
	$retval = '<option></option>' . "\n";
	// loop on the dropdown array and print all available options for that
	// field.
	$functions = $GLOBALS['dbi']->types->getFunctions($field['True_Type']);
	foreach ($functions as $function) {
	$retval .= '<option';
	if (isset($foreignData['foreign_link']) && $foreignData['foreign_link'] !== false
	&& $default_function
	=== $function) {
	$retval .= ' selected="selected"';
	}
	$retval .= '>' . $function . '</option>' . "\n";
	$dropdown_built[$function] = true;

[williamdes]

Waiting for approvers on #15935