New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value field contains whitespace #13593

Closed
stevenwdv opened this Issue Aug 18, 2017 · 2 comments

Comments

Projects
None yet
5 participants
@stevenwdv
Contributor

stevenwdv commented Aug 18, 2017

  • Create a new table
  • Set the Default column to As defined:
  • Select everything in the textarea; as you can see it contains whitespace

view-source shows this:

    <textarea name="field_default_value[0]"
              cols="15"
              class="textfield
              default_value">
            </textarea>

The same issue occurs when editing a column with a default value:

    <textarea name="field_default_value[0]"
              cols="15"
              class="textfield
              default_value">
        0    </textarea>

The whitespace should be removed.
This issue should be fairly easy to fix.

@nehalko3087

This comment has been minimized.

Show comment
Hide comment
@nehalko3087

nehalko3087 Aug 19, 2017

Contributor

Please specify the phpmyadmin version you are using. I checked this in Version information: 4.7.3 and cannot find a textarea, instead an input field for the default value input after choosing As defined

Contributor

nehalko3087 commented Aug 19, 2017

Please specify the phpmyadmin version you are using. I checked this in Version information: 4.7.3 and cannot find a textarea, instead an input field for the default value input after choosing As defined

@devenbansod

This comment has been minimized.

Show comment
Hide comment
@devenbansod

devenbansod Aug 20, 2017

Member

Hi @nehalko3087, you should be able to reproduce the behavior if the value of $cfg['CharEditing'] is set to 'textarea' (against the default value of 'input').

Member

devenbansod commented Aug 20, 2017

Hi @nehalko3087, you should be able to reproduce the behavior if the value of $cfg['CharEditing'] is set to 'textarea' (against the default value of 'input').

nehalko3087 added a commit to nehalko3087/phpmyadmin that referenced this issue Aug 20, 2017

@nijel nijel self-assigned this Aug 21, 2017

@nijel nijel added this to the 4.8.0 milestone Aug 21, 2017

@nijel nijel closed this in 7c8e33b Aug 21, 2017

nijel added a commit that referenced this issue Aug 21, 2017

Merge pull request #13597 from nehalko3087/master
Fix #13593 : removed whitespace in textarea for column default value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment