New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twig introduces ctype dependecy #13611

Closed
nijel opened this Issue Aug 23, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@nijel
Member

nijel commented Aug 23, 2017

After fixing this in 4.7 series (see #13162), the ctype dependecy is there again in master, this time through Twig:

PHP message: PHP Fatal error:  Uncaught Error: Call to undefined function ctype_alpha() in /www/vendor/twig/twig/lib/Twig/Loader/Filesystem.php:281

Stack trace:

#0 /www/vendor/twig/twig/lib/Twig/Loader/Filesystem.php(99): Twig_Loader_Filesystem->isAbsolutePath('templates/')
#1 /www/vendor/twig/twig/lib/Twig/Loader/Filesystem.php(82): Twig_Loader_Filesystem->addPath('templates/', '__main__')
#2 /www/vendor/twig/twig/lib/Twig/Loader/Filesystem.php(40): Twig_Loader_Filesystem->setPaths(Array)
#3 /www/libraries/classes/Template.php(63): Twig_Loader_Filesystem->__construct('templates/')
#4 /www/libraries/classes/Template.php(93): PhpMyAdmin\Template->__construct('select_lang', Array, Array)
#5 /www/libraries/classes/LanguageManager.php(943): PhpMyAdmin\Template::get('select_lang')
#6 /www/libraries/classes/Plugins/Auth/AuthenticationCookie.php(169): PhpMyAdmin\LanguageManager->getSelectorDisplay(true, false)
#7 /www/libraries/common.inc.php(675): PhpMyAdmin\Plugins\Auth\AuthenticationCookie->auth()
#8 /www/ind

See https://travis-ci.org/phpmyadmin/docker/jobs/267602049

The question is whether we will really try to work without ctype or rather declare it as a dependency...

@nijel nijel added the bug label Aug 23, 2017

@nijel nijel added this to the 4.8.0 milestone Aug 23, 2017

@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel
Member

nijel commented Aug 24, 2017

@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Aug 28, 2017

Member

If we decide to add ctype dependency, we could simplify some our code as well, at least in SQL parser: phpmyadmin/sql-parser@5cb3993

Member

nijel commented Aug 28, 2017

If we decide to add ctype dependency, we could simplify some our code as well, at least in SQL parser: phpmyadmin/sql-parser@5cb3993

@nijel nijel self-assigned this Sep 4, 2017

@nijel nijel closed this in 0c32545 Sep 4, 2017

nijel added a commit that referenced this issue Sep 4, 2017

Add runtime check for ctype extension
Issue #13611

Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment