Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase input field width for varchar(255) #13627

Closed
OlafvdSpek opened this issue Aug 29, 2017 · 11 comments · Fixed by #14379
Closed

Increase input field width for varchar(255) #13627

OlafvdSpek opened this issue Aug 29, 2017 · 11 comments · Fixed by #14379
Assignees
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Milestone

Comments

@OlafvdSpek
Copy link

OlafvdSpek commented Aug 29, 2017

The input field width (on Insert Row page) is currently 40 chars, could this be increased?
Perhaps the value fields could use all remaining width in the table.

@deBilla
Copy link

deBilla commented Aug 29, 2017

if you need input field more than 40 chars you can use text field instead of varchar.

@OlafvdSpek
Copy link
Author

I don't need / want a text field.. varchar(255) is fine for me.

@stevenwdv
Copy link
Contributor

You could set $cfg['CharEditing'] to 'textarea'.

@OlafvdSpek
Copy link
Author

I think it's a textarea already, though I don't need / want a textarea for a single-line varchar.
I'd prefer the defaults to be improved, so other users benefit too.

@nijel nijel added enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface labels Sep 4, 2017
@ankitjain28may
Copy link
Contributor

Hey, The field is expandable so it isnt any problem.

@stevenwdv
Copy link
Contributor

@ankitjain28may I think that's only with the textarea right?

@ankitjain28may
Copy link
Contributor

Yupp

@ftrotter
Copy link

ftrotter commented Feb 4, 2018

Agree completely with Oladvdspek. The old interface was pretty smooth for doing simple data entry for relatively small amounts of text. Now, with the need to manually mouse drag to expand the field even to read the very first line of text correctly, the interface is useless for doing quick data entry. To re-emphasize, the fact that it is "expandable" is not the solution here, it is the problem. For under a 1000 characters it is pretty simple to figure out exactly the right size of textarea, and there is plenty of screen space on modern monitors to expand.

This is problem that is simpler to show than to describe.

phpmyadmin_input_size_problem

Also, this is not technically an enhancement. Old versions of this interface were useable without a mouse for data entry. In the current interface text entered into the text area cannot even be read without using a mouse to expand the textarea. So this is a net loss of functionality, ergo should be classified as a bug.

Thank you for your work on this awesome product.

-FT

@aroralakshya
Copy link
Contributor

aroralakshya commented Mar 3, 2018

@ibennetch, The function to add textareas in this page is getTextarea which resides in the file libraries/classes/InsertEdit.php.
The rows and cols attributes are set using the global config set. A possible way to implement this enhancement would be to overwrite the rows and cols for the varchar fields. Would it be alright to do so??

@MauricioFauth
Copy link
Member

MauricioFauth commented Mar 31, 2018

@OlafvdSpek @ftrotter The default size of the textarea can be changed with $cfg['CharTextareaCols'] and $cfg['CharTextareaRows']. For example:

$cfg['CharTextareaCols'] = 100;
$cfg['CharTextareaRows'] = 5;

@OlafvdSpek
Copy link
Author

@MauricioFauth That's not the default size, that's the initial size. Setting the default size requires write access to the git repo. ;)

@ibennetch ibennetch added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label May 19, 2018
@MauricioFauth MauricioFauth self-assigned this Aug 3, 2018
@MauricioFauth MauricioFauth added this to the 5.0.0 milestone Aug 3, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants