New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase input field width for varchar(255) #13627

Closed
OlafvdSpek opened this Issue Aug 29, 2017 · 11 comments

Comments

Projects
None yet
9 participants
@OlafvdSpek

OlafvdSpek commented Aug 29, 2017

The input field width (on Insert Row page) is currently 40 chars, could this be increased?
Perhaps the value fields could use all remaining width in the table.

@CredOz

This comment has been minimized.

CredOz commented Aug 29, 2017

if you need input field more than 40 chars you can use text field instead of varchar.

@OlafvdSpek

This comment has been minimized.

OlafvdSpek commented Aug 30, 2017

I don't need / want a text field.. varchar(255) is fine for me.

@stevenwdv

This comment has been minimized.

Contributor

stevenwdv commented Aug 30, 2017

You could set $cfg['CharEditing'] to 'textarea'.

@OlafvdSpek

This comment has been minimized.

OlafvdSpek commented Aug 30, 2017

I think it's a textarea already, though I don't need / want a textarea for a single-line varchar.
I'd prefer the defaults to be improved, so other users benefit too.

@ankitjain28may

This comment has been minimized.

Contributor

ankitjain28may commented Sep 20, 2017

Hey, The field is expandable so it isnt any problem.

@stevenwdv

This comment has been minimized.

Contributor

stevenwdv commented Sep 20, 2017

@ankitjain28may I think that's only with the textarea right?

@ankitjain28may

This comment has been minimized.

Contributor

ankitjain28may commented Sep 20, 2017

Yupp

@ftrotter

This comment has been minimized.

ftrotter commented Feb 4, 2018

Agree completely with Oladvdspek. The old interface was pretty smooth for doing simple data entry for relatively small amounts of text. Now, with the need to manually mouse drag to expand the field even to read the very first line of text correctly, the interface is useless for doing quick data entry. To re-emphasize, the fact that it is "expandable" is not the solution here, it is the problem. For under a 1000 characters it is pretty simple to figure out exactly the right size of textarea, and there is plenty of screen space on modern monitors to expand.

This is problem that is simpler to show than to describe.

phpmyadmin_input_size_problem

Also, this is not technically an enhancement. Old versions of this interface were useable without a mouse for data entry. In the current interface text entered into the text area cannot even be read without using a mouse to expand the textarea. So this is a net loss of functionality, ergo should be classified as a bug.

Thank you for your work on this awesome product.

-FT

@nulll-pointer

This comment has been minimized.

Contributor

nulll-pointer commented Mar 3, 2018

@ibennetch, The function to add textareas in this page is getTextarea which resides in the file libraries/classes/InsertEdit.php.
The rows and cols attributes are set using the global config set. A possible way to implement this enhancement would be to overwrite the rows and cols for the varchar fields. Would it be alright to do so??

shucon added a commit to shucon/phpmyadmin that referenced this issue Mar 25, 2018

Increase input field width for varchar(255)
Fixes: phpmyadmin#13627

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

@shucon shucon referenced this issue Mar 25, 2018

Closed

Increase input field width for varchar(255) #14124

4 of 4 tasks complete
@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Mar 31, 2018

@OlafvdSpek @ftrotter The default size of the textarea can be changed with $cfg['CharTextareaCols'] and $cfg['CharTextareaRows']. For example:

$cfg['CharTextareaCols'] = 100;
$cfg['CharTextareaRows'] = 5;
@OlafvdSpek

This comment has been minimized.

OlafvdSpek commented Mar 31, 2018

@mauriciofauth That's not the default size, that's the initial size. Setting the default size requires write access to the git repo. ;)

@ibennetch ibennetch added the has-pr label May 19, 2018

@nulll-pointer nulll-pointer referenced this issue Jun 15, 2018

Merged

Increase input field width for varchar #14379

0 of 4 tasks complete

@mauriciofauth mauriciofauth self-assigned this Aug 3, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Aug 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment