New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modal to login after session expired #13654

Closed
AmirHosseinKarimi opened this Issue Sep 5, 2017 · 7 comments

Comments

Projects
None yet
5 participants
@AmirHosseinKarimi

AmirHosseinKarimi commented Sep 5, 2017

Hi, Many times i want continue my work on phpmyadmin when click on something this will go to login page and i lost my data on page.
I think its good idea to create a login modal and open when detect session expired, and login on modal immediately and do not redirect to any page. Just like Wordpress.
Thanks all.

@ankitjain28may

This comment has been minimized.

Contributor

ankitjain28may commented Sep 20, 2017

@nijel I would like to work on this issue if no one is working.

@nijel

This comment has been minimized.

Member

nijel commented Sep 28, 2017

@ankitjain28may feel free to look at this

@ankitjain28may

This comment has been minimized.

Contributor

ankitjain28may commented Sep 28, 2017

Sure

@shucon

This comment has been minimized.

Contributor

shucon commented Feb 26, 2018

I'm starting to work on this.

@shucon shucon referenced this issue Feb 28, 2018

Merged

Restore SQL query after session expire #14046

4 of 4 tasks complete

@nijel nijel closed this in #14046 Mar 16, 2018

@shucon

This comment has been minimized.

Contributor

shucon commented Mar 16, 2018

@nijel please reopen this issue as it is only partially fixed and I think something similar be done for insert page.

@nijel nijel reopened this Mar 16, 2018

@nijel

This comment has been minimized.

Member

nijel commented Mar 16, 2018

Okay, whenever commit contains "fixes ....", the issue is closed automatically. If yo do not want to close the issue, just use "issue ....".

@shucon

This comment has been minimized.

Contributor

shucon commented Mar 16, 2018

Okay, I'll take care . I thought Partially-fixes also works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment