Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed columns header on list #13713

Closed
AmirHosseinKarimi opened this issue Sep 29, 2017 · 26 comments
Closed

Fixed columns header on list #13713

AmirHosseinKarimi opened this issue Sep 29, 2017 · 26 comments
Assignees
Labels
enhancement A feature request for improving phpMyAdmin good first issue hacktoberfest has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete newbie ui Issues relating to the user interface
Milestone

Comments

@AmirHosseinKarimi
Copy link

AmirHosseinKarimi commented Sep 29, 2017

Its fully explained on screenshot, but for certain: Fixed column orders and grid layout not matched by table rows.

I think its better to move column comment to tooltips and do not show inside of column name

Expected behaviour

screenshot from 2017-09-29 16-50-01

Actual behaviour

screenshot from 2017-09-29 16-42-54

@nijel
Copy link
Contributor

nijel commented Oct 2, 2017

Well, the black boxes make the screenshots a bit hard to read. Do you propose to allow linebreak between column name and comment? That sounds legit.

@nijel nijel added enhancement A feature request for improving phpMyAdmin hacktoberfest newbie ui Issues relating to the user interface labels Oct 2, 2017
@AmirHosseinKarimi
Copy link
Author

Sorry but black boxes is just for privacy.
No, I do not used; And can use line break on column name or comments?!
I think its just CSS problem.

@AmirHosseinKarimi
Copy link
Author

I found somethings. When page load directly(not ajax) and left panel is closed the header menu is OK, But when load AJAX its not OK. May something on JS codes

@nijel
Copy link
Contributor

nijel commented Oct 3, 2017

Indeed there is some javascript involved, for me it loads correctly in both cases. However I think adding zero width space between column name and comment would fix it.

@AmirHosseinKarimi
Copy link
Author

@nijel Its good idea, column name does not have any space, But columns comments has and i think its allow to use space in column comments.
I think its better to move column comment to column header name tooltip its more cleared and beauty.
Thanks anyway.

@Hann
Copy link

Hann commented Oct 9, 2017

I want to try to fix this issue.
@AmirHosseinKarimi if you don't mind, can you explain more steps which you actioned?

@AmirHosseinKarimi
Copy link
Author

@Hann Hi, its good sound.
Nothing, I do not any abnormally action.
Its a problem in my case and when:

  1. I go to page directly (from url) headers are normally.
  2. when i go to page with phpmyadmin links (ajax) it does not show correctly.
    How can i report any need information?!

@Hann
Copy link

Hann commented Oct 12, 2017

@AmirHosseinKarimi
I made the table which is similar to table you made. and... i was actioning steps below

  1. closed left panel
  2. clicked the Structure button
  3. clicked the Browse button

screen shot 2017-10-12 at 11 52 27 pm

but.. this image is different from your actual behavior image.
so I want to know column name and comment at least the length name or comment.

@shucon
Copy link
Contributor

shucon commented Oct 14, 2017

Anyone still working on this issue?

@Hann
Copy link

Hann commented Oct 14, 2017

Yes. I am trying to find the linebreak

@SoumyadeepJana
Copy link

@AmirHosseinKarimi I want to work on this issue.How will I reproduce it and in which file does its code contain?

@AmirHosseinKarimi
Copy link
Author

Hi, I found problem,
This problem happen only when (even) one column has comment!
No matter one character or how many character in comment...
I thinks something is wrong to apply comment text to with of column header to process it on sticky header.
When i clear all column comments its good and does not have problem.
Anyone has this problem too?

@AmirHosseinKarimi
Copy link
Author

@Hann In your case (screen shot) column comment text is, in bottom of column name, but in my case it join after column name, like bottom screen shot:
screenshot from 2017-10-15 22-46-10

Please create some column like this and test its my case problem or its for script?!

@kazoli
Copy link

kazoli commented Oct 16, 2017

Hi,

I have found the same problem with 4.7.4. If I add css value display: block; in table.sticky_columns to span.tblcomment then the problem is solved.
untitled-2

@Hann
Copy link

Hann commented Nov 16, 2017

@AmirHosseinKarimi Hello... do you use safari? It seems to appear in safari i think. i get the issue on safari

@kazoli
Copy link

kazoli commented Nov 16, 2017

This error appears to me in Chrome and FF too. Here: phpMyAdmin\themes\pmahomme\css\common.css.php for .tblcomment needs a display: block; command and it solves the problem.

@vikasmahato
Copy link

Can I work on this issue? I am just getting started with opensource!!

@nijel
Copy link
Contributor

nijel commented Dec 18, 2017

@vikasmahato Feel free to work on this, AFAIK nobody is working on it right now.

@irenesalomo
Copy link

Hi @vikasmahato , are you still working on this issue?
If not, I'm happy to work on this.

@vikasmahato
Copy link

@irenesalomo I am not working on it currently. You can work on it.

@rijaspk
Copy link
Contributor

rijaspk commented Jan 30, 2018

@nijel
Hi Nije
I would like to work on this issue,but the problem is i cant replicate the issue.I tried creating a table with 7 columns,some of them with long comments but headers are perfect.

@AmirHosseinKarimi
Copy link
Author

Hi, Is this problem fixed?

@irenesalomo
Copy link

irenesalomo commented Aug 11, 2018 via email

@AmirHosseinKarimi
Copy link
Author

@irenesalomo Ok thanks, I will work on this.

@dmitrystas
Copy link

have the same issue, phpmyadmin 4.8.3

@CXZ7720
Copy link

CXZ7720 commented Nov 3, 2018

Hello. I'm working on this issue. But I can't replicate the situation in 4.8.3. Could you give me more info about it? @dmitrystas

@murex971 murex971 mentioned this issue Apr 2, 2019
6 tasks
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Apr 2, 2019
@MauricioFauth MauricioFauth self-assigned this Apr 16, 2019
@MauricioFauth MauricioFauth added this to the 4.8.6 milestone Apr 16, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement A feature request for improving phpMyAdmin good first issue hacktoberfest has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete newbie ui Issues relating to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.