New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copied table data add "1" after column name which had order by parameter #13727

Closed
anantjain6 opened this Issue Oct 10, 2017 · 10 comments

Comments

Projects
None yet
8 participants
@anantjain6
Contributor

anantjain6 commented Oct 10, 2017

Steps to reproduce

  1. Select any table
  2. order by any column
  3. from menu/option in bottom on table select "copy to clipboard"

Expected behaviour

"1" do not depict the why it is used for
Maybe we can add [Asc] [Desc] or anything else or nothing

Actual behaviour

"1" is added after column name which had order by parameter
copy

Server configuration

Online demo

phpMyAdmin version: 4.7.4

Client configuration

Browser: 61.0.3163.100 (Official Build) (64-bit)

Operating system: Ubuntu 16.0.4 LTS

@guilherme-gmonteiro

This comment has been minimized.

Show comment
Hide comment
@guilherme-gmonteiro

guilherme-gmonteiro Oct 12, 2017

I Will work on this!

guilherme-gmonteiro commented Oct 12, 2017

I Will work on this!

shucon added a commit to shucon/phpmyadmin that referenced this issue Oct 12, 2017

Fix table column name
Fixes phpmyadmin#13727

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

@shucon shucon referenced this issue Oct 12, 2017

Closed

Fix table column name #13736

2 of 4 tasks complete
@acekyd

This comment has been minimized.

Show comment
Hide comment
@acekyd

acekyd Oct 12, 2017

I think there's been a misunderstanding and the fix on #13736 might not be right as well.

The 1 that is added is used to represent which columns that are being ordered. so in a case of ORDER BY column1, column2 ASC, these columns are numbered to know which, removing them or changing to whether ASC or DESC might not work for that. Looking forward to hearing your thoughts on this @nijel @anantjain6

acekyd commented Oct 12, 2017

I think there's been a misunderstanding and the fix on #13736 might not be right as well.

The 1 that is added is used to represent which columns that are being ordered. so in a case of ORDER BY column1, column2 ASC, these columns are numbered to know which, removing them or changing to whether ASC or DESC might not work for that. Looking forward to hearing your thoughts on this @nijel @anantjain6

@anantjain6

This comment has been minimized.

Show comment
Hide comment
@anantjain6

anantjain6 Oct 13, 2017

Contributor

@acekyd I'm also not sure that what can be best way
above table we can add line of text like "order by column1, coulmn2 desc"

Contributor

anantjain6 commented Oct 13, 2017

@acekyd I'm also not sure that what can be best way
above table we can add line of text like "order by column1, coulmn2 desc"

@akritianand

This comment has been minimized.

Show comment
Hide comment
@akritianand

akritianand Oct 16, 2017

Contributor

Hello. I've just submitted a pull request. The column which is sorted shows [Asc/Desc] next to it. The ORDER BY column name does show in the pasted text already.

Contributor

akritianand commented Oct 16, 2017

Hello. I've just submitted a pull request. The column which is sorted shows [Asc/Desc] next to it. The ORDER BY column name does show in the pasted text already.

@shucon

This comment has been minimized.

Show comment
Hide comment
@shucon

shucon Oct 16, 2017

Contributor

@akritianand I was already working on this issue , and have already submitted a PR as mentioned above :)

Contributor

shucon commented Oct 16, 2017

@akritianand I was already working on this issue , and have already submitted a PR as mentioned above :)

@ibennetch

This comment has been minimized.

Show comment
Hide comment
@ibennetch

ibennetch Oct 18, 2017

Member

i think that, because of the triangle icon, we don't need ASC and DESC.

I believe the 1 originally was there as a hint that there's a tool tip there, so the user can hover over for help. The question mark help icon may be a better fit here, and doesn't have to be in a particular column header, either, though I don't have a better idea other than hanging off the side of the table header to the far right of the existing columns.

Member

ibennetch commented Oct 18, 2017

i think that, because of the triangle icon, we don't need ASC and DESC.

I believe the 1 originally was there as a hint that there's a tool tip there, so the user can hover over for help. The question mark help icon may be a better fit here, and doesn't have to be in a particular column header, either, though I don't have a better idea other than hanging off the side of the table header to the far right of the existing columns.

@acekyd

This comment has been minimized.

Show comment
Hide comment
@acekyd

acekyd Oct 18, 2017

I agree with @ibennetch. We don't need ASC and DESC because of the triangle icon.

But I still think we are overlooking the role the "1" is playing there. Once again, the 1 shows the ORDER BY status. So if you are ordering by 2 different columns, it numbers them.

I think the best solution here is to hide the "1" whenever you are ordering by less than 2 columns. Otherwise, it shows the numbering across.

acekyd commented Oct 18, 2017

I agree with @ibennetch. We don't need ASC and DESC because of the triangle icon.

But I still think we are overlooking the role the "1" is playing there. Once again, the 1 shows the ORDER BY status. So if you are ordering by 2 different columns, it numbers them.

I think the best solution here is to hide the "1" whenever you are ordering by less than 2 columns. Otherwise, it shows the numbering across.

@ibennetch

This comment has been minimized.

Show comment
Hide comment
@ibennetch

ibennetch Oct 18, 2017

Member

Oh, right, I had forgotten for a moment that it shows the number of ordered by columns. I agree with @acekyd about the desired behavior.

Member

ibennetch commented Oct 18, 2017

Oh, right, I had forgotten for a moment that it shows the number of ordered by columns. I agree with @acekyd about the desired behavior.

@shucon

This comment has been minimized.

Show comment
Hide comment
@shucon

shucon Nov 2, 2017

Contributor

@nijel this issue is pending from a long time.
Your views on the same?

Contributor

shucon commented Nov 2, 2017

@nijel this issue is pending from a long time.
Your views on the same?

@scarletphoenix

This comment has been minimized.

Show comment
Hide comment
@scarletphoenix

scarletphoenix Nov 14, 2017

This issue still up for fixing?

scarletphoenix commented Nov 14, 2017

This issue still up for fixing?

xypXiong added a commit to xypXiong/phpmyadmin that referenced this issue Nov 20, 2017

fix phpmyadmin#13727 copied table data add number of orders
Signed-off-by: yanping <xyp.xiong@gmail.com>

@nijel nijel closed this in f65c3dc Nov 28, 2017

@nijel nijel self-assigned this Nov 28, 2017

@nijel nijel added this to the 4.8.0 milestone Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment