Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Copied table data add "1" after column name which had order by parameter #13727
Steps to reproduce
"1" do not depict the why it is used for
phpMyAdmin version: 4.7.4
Browser: 61.0.3163.100 (Official Build) (64-bit)
Operating system: Ubuntu 16.0.4 LTS
added a commit
Oct 12, 2017
I think there's been a misunderstanding and the fix on #13736 might not be right as well.
i think that, because of the triangle icon, we don't need ASC and DESC.
I believe the 1 originally was there as a hint that there's a tool tip there, so the user can hover over for help. The question mark help icon may be a better fit here, and doesn't have to be in a particular column header, either, though I don't have a better idea other than hanging off the side of the table header to the far right of the existing columns.
I agree with @ibennetch. We don't need ASC and DESC because of the triangle icon.
But I still think we are overlooking the role the "1" is playing there. Once again, the 1 shows the ORDER BY status. So if you are ordering by 2 different columns, it numbers them.
I think the best solution here is to hide the "1" whenever you are ordering by less than 2 columns. Otherwise, it shows the numbering across.