New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken help links in Variables tab #13805

Closed
ibennetch opened this Issue Nov 9, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@ibennetch
Member

ibennetch commented Nov 9, 2017

Steps to reproduce

  1. Enter the "Variables" tab from the main page
  2. Click any help link; the question mark icon at the top of the page or any linked text like 'datadir'

Expected behaviour

Individual variables should have the help icon behind them, I think. Regardless, the link should open correctly.

Actual behaviour

( ! ) Fatal error: Call to a member function getDisplay() on null in /var/www/pma-dev/fork/libraries/classes/Response.php on line 266
Call Stack
#	Time	Memory	Function	Location
1	0.0320	132948	{main}( )	../url.php:0
2	0.0382	485708	PhpMyAdmin\Response::getInstance( )	../url.php:20
3	0.0382	485916	PhpMyAdmin\Response->__construct( )	../Response.php:134
4	0.0384	522812	PhpMyAdmin\Header->__construct( )	../Response.php:100
5	0.0388	532304	PhpMyAdmin\Header->_addDefaultScripts( )	../Header.php:137
6	0.0395	547660	PhpMyAdmin\Header->getJsParamsCode( )	../Header.php:207
7	0.0395	547724	PhpMyAdmin\Header->getJsParams( )	../Header.php:280
8	0.0879	631816	PhpMyAdmin\Response->response( )	../Response.php:0
9	0.0884	633812	PhpMyAdmin\Response->_htmlResponse( )	../Response.php:438
10	0.0884	633860	PhpMyAdmin\Response->_getDisplay( )	../Response.php:279

Server configuration

Operating system:
Debian Linux
Web server:
Apache
Database:
MariaDB 10.3.2
PHP version:
5.6.30
phpMyAdmin version:
master

@smileytechguy

This comment has been minimized.

Show comment
Hide comment
@smileytechguy

smileytechguy Nov 9, 2017

Contributor

I too have this issue, however on any page and with older commits. Perhaps an issue with a dependency?

Contributor

smileytechguy commented Nov 9, 2017

I too have this issue, however on any page and with older commits. Perhaps an issue with a dependency?

@mauriciofauth

This comment has been minimized.

Show comment
Hide comment
@mauriciofauth

mauriciofauth Nov 9, 2017

Member

Apparently it's broken since 60c1b32.

Member

mauriciofauth commented Nov 9, 2017

Apparently it's broken since 60c1b32.

@mauriciofauth mauriciofauth added the bug label Nov 9, 2017

mauriciofauth referenced this issue Nov 10, 2017

Remove usage of $GLOBALS['userlink']
The links are internal to DatabaseInterface and user link is default.

Signed-off-by: Michal Čihař <michal@cihar.com>

@nijel nijel self-assigned this Nov 13, 2017

@nijel nijel added this to the 4.8.0 milestone Nov 13, 2017

@nijel nijel closed this in 895ee14 Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment