New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm when closing tab/window with an unsaved query #13821

Closed
nunoperalta opened this Issue Nov 19, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@nunoperalta

nunoperalta commented Nov 19, 2017

Steps to reproduce

  1. Open the SQL Query box
  2. Type a query
  3. Close Window/Tab

Expected behaviour

I should get a popup confirmation asking if I want to close the window.
(the same popup that I get if I click on a link instead)

Actual behaviour

Window closes and I lose the unsaved query.

Related issue

If I open the SQL Query Box and just do "Ctrl + V" to paste a query from the clipboard, clicking on a link will not give the popup either (note that clicking on a link DOES trigger a popup at the moment, if I type the query manually)

Server configuration

phpMyAdmin version: 4.7.5 - also happens with DEMO 4.8.0

Client configuration

Browser: Google Chrome

Operating system: Windows 10

@nijel nijel self-assigned this Nov 28, 2017

@nijel nijel added the enhancement label Nov 28, 2017

@nijel nijel added this to the 4.7.6 milestone Nov 28, 2017

@nijel nijel closed this in 784fbcd Nov 28, 2017

ibennetch added a commit that referenced this issue Dec 1, 2017

Lock page when changes are done in the SQL editor
The CodeMirror does not update underlying textarea in all cases, so we
need to handle it directly.

Fixes #13821

Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment