New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two factor: U2F doesn't work in Firefox 57 with U2F enabled #13830

Closed
nijel opened this Issue Nov 23, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@nijel
Member

nijel commented Nov 23, 2017

Apparently implementation of native U2F in Firefox 57 is different than in Chrome and leads to error:

TypeError: setting getter-only property "u2f"

@nijel nijel added the bug label Nov 23, 2017

@nijel nijel added this to the 4.8.0 milestone Nov 23, 2017

@nijel nijel self-assigned this Nov 23, 2017

@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Nov 23, 2017

Member

This seems to be seen in other projects as well, so probably is not our bug:

Member

nijel commented Nov 23, 2017

This seems to be seen in other projects as well, so probably is not our bug:

@nijel nijel closed this in 4928103 Nov 23, 2017

@Vednier

This comment has been minimized.

Show comment
Hide comment
@Vednier

Vednier Dec 2, 2017

probably is not our bug:

Not Mozilla's either - https://bugzilla.mozilla.org/show_bug.cgi?id=1411710#c3

"Sadly, the U2F standard doesn't specify much of anything about how the u2f object works -- ours is not replaceable, being implemented in C++, while IIUC Google's is implemented by that u2f-api.js file."

Vednier commented Dec 2, 2017

probably is not our bug:

Not Mozilla's either - https://bugzilla.mozilla.org/show_bug.cgi?id=1411710#c3

"Sadly, the U2F standard doesn't specify much of anything about how the u2f object works -- ours is not replaceable, being implemented in C++, while IIUC Google's is implemented by that u2f-api.js file."

@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Dec 2, 2017

Member

I've fixed that by using https://github.com/mastahyeti/u2f-api, what seems to work just fine in both cases.

Member

nijel commented Dec 2, 2017

I've fixed that by using https://github.com/mastahyeti/u2f-api, what seems to work just fine in both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment