New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid links containing SQL query #13866

Closed
nijel opened this Issue Dec 14, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@nijel
Member

nijel commented Dec 14, 2017

Since 72f109a we accept SQL queries from POST requests only (this is pretty much followup for #6297), however some of the code still generates links with sql_query parameter.

This should be fixed for 4.8.0 release and those probably should use Util::linkOrButton which automatically generates forms for URLs containing SQL queries.

@nijel nijel added the bug label Dec 14, 2017

@nijel nijel added this to the 4.8.0 milestone Dec 14, 2017

nijel added a commit that referenced this issue Dec 15, 2017

Handle data-post with leading ?
This makes it easier to convert existing code.

Issue #13866

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Dec 15, 2017

Adjust table truncate operation to use POST
Issue #13866

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Dec 15, 2017

Adjust table drop operation to use POST
Issue #13866

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Dec 15, 2017

Adjust adding table key operations to use POST
Issue #13866

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Dec 15, 2017

Adjust browsing distinct values to use POST
Issue #13866

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Dec 15, 2017

Adjust partition manipulations to use POST
Issue #13866

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Dec 15, 2017

Adjust optimize table to use POST
Issue #13866

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Dec 15, 2017

Adjust field drop to use POST
Issue #13866

Signed-off-by: Michal Čihař <michal@cihar.com>

@nijel nijel self-assigned this Dec 15, 2017

nijel added a commit that referenced this issue Dec 15, 2017

Adjust RTE oprations to use POST
Issue #13866

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Dec 15, 2017

Adjust table operations to use POST
Issue #13866

Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Dec 15, 2017

Member

I've fixed all what I could find, however it's quite likely that I've missed something, so leaving this open for a while.

Member

nijel commented Dec 15, 2017

I've fixed all what I could find, however it's quite likely that I've missed something, so leaving this open for a while.

@nijel nijel closed this Dec 18, 2017

mauriciofauth added a commit to mauriciofauth/phpmyadmin that referenced this issue Feb 22, 2018

Handle data-post with leading ?
This makes it easier to convert existing code.

Issue phpmyadmin#13866

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit f059baa)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

mauriciofauth added a commit to mauriciofauth/phpmyadmin that referenced this issue Feb 22, 2018

Adjust table truncate operation to use POST
Issue phpmyadmin#13866

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit ff20564)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

mauriciofauth added a commit to mauriciofauth/phpmyadmin that referenced this issue Feb 22, 2018

Adjust table drop operation to use POST
Issue phpmyadmin#13866

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit 8332861)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

mauriciofauth added a commit to mauriciofauth/phpmyadmin that referenced this issue Feb 22, 2018

Adjust adding table key operations to use POST
Issue phpmyadmin#13866

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit 6ee2f12)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

mauriciofauth added a commit to mauriciofauth/phpmyadmin that referenced this issue Feb 22, 2018

Adjust browsing distinct values to use POST
Issue phpmyadmin#13866

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit e7eaea8)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

mauriciofauth added a commit to mauriciofauth/phpmyadmin that referenced this issue Feb 22, 2018

Adjust partition manipulations to use POST
Issue phpmyadmin#13866

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit 599a981)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

mauriciofauth added a commit to mauriciofauth/phpmyadmin that referenced this issue Feb 22, 2018

Adjust optimize table to use POST
Issue phpmyadmin#13866

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit 7508205)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

mauriciofauth added a commit to mauriciofauth/phpmyadmin that referenced this issue Feb 22, 2018

Adjust field drop to use POST
Issue phpmyadmin#13866

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit 613a146)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

mauriciofauth added a commit to mauriciofauth/phpmyadmin that referenced this issue Feb 22, 2018

Adjust RTE oprations to use POST
Issue phpmyadmin#13866

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit 2bc8721)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

mauriciofauth added a commit to mauriciofauth/phpmyadmin that referenced this issue Feb 22, 2018

Adjust table operations to use POST
Issue phpmyadmin#13866

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit 6b5d535)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

mauriciofauth added a commit to mauriciofauth/phpmyadmin that referenced this issue Feb 22, 2018

Adjust table operations to use POST
Issue phpmyadmin#13866

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit 6b5d535)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment