New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create/Edit routine charset bug #13889

Closed
williamdes opened this Issue Dec 26, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@williamdes
Member

williamdes commented Dec 26, 2017

Steps to reproduce

  1. Navigate to a database > Routines > Add routine
  2. Fill required informations (Name, content, default parameter name)
  3. Edit the default parameter > set type to varchar > set charset to your favorite charset
  4. Change the type to binary
  5. Send the form "Go"

Expected behaviour

The routine should be created

Actual behaviour

Error : Syntax error
pma_bug

More information

Same issue when editing the routine
Same issue with VARBINARY, SERIAL, TINYBLOB, ...

No issue with GEOMETRY, DATE, BOOLEAN, YEAR, ...

Server configuration

PHP version: 7.0.19-1
phpMyAdmin version: 4.7.7
Database: Server version: 10.2.10-MariaDB - Source distribution

Client configuration

Browser: 63.0.3239.108 (64 bits)

@devenbansod devenbansod added the bug label Dec 26, 2017

@williamdes williamdes referenced this issue Dec 26, 2017

Closed

. #13891

williamdes added a commit to williamdes/phpmyadmintest that referenced this issue Dec 26, 2017

Patch for issue phpmyadmin#13889
Emptied the value when it is hidden.
Fixes the issue phpmyadmin#13889

Signed-off-by: William Desportes <williamdes@wdes.fr>

williamdes added a commit to williamdes/phpmyadmintest that referenced this issue Jan 20, 2018

Patch for issue phpmyadmin#13889
Fixes the issue phpmyadmin#13889

Signed-off-by: William Desportes <williamdes@wdes.fr>

williamdes added a commit to williamdes/phpmyadmintest that referenced this issue Feb 12, 2018

Patch for issue phpmyadmin#13889
Fixes the issue phpmyadmin#13889

Signed-off-by: William Desportes <williamdes@wdes.fr>

nijel added a commit that referenced this issue Feb 20, 2018

Merge pull request #13892 from williamdes/patch-2
Fix charset error when creating/editing routines; bug #13889

@nijel nijel self-assigned this Feb 20, 2018

@nijel nijel added this to the 4.8.0 milestone Feb 20, 2018

@nijel

This comment has been minimized.

Member

nijel commented Feb 20, 2018

Fixed by #13892.

@nijel nijel closed this Feb 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment