Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create/Edit routine charset bug #13889

Closed
williamdes opened this issue Dec 26, 2017 · 1 comment
Closed

Create/Edit routine charset bug #13889

williamdes opened this issue Dec 26, 2017 · 1 comment
Assignees
Milestone

Comments

@williamdes
Copy link
Member

@williamdes williamdes commented Dec 26, 2017

Steps to reproduce

  1. Navigate to a database > Routines > Add routine
  2. Fill required informations (Name, content, default parameter name)
  3. Edit the default parameter > set type to varchar > set charset to your favorite charset
  4. Change the type to binary
  5. Send the form "Go"

Expected behaviour

The routine should be created

Actual behaviour

Error : Syntax error
pma_bug

More information

Same issue when editing the routine
Same issue with VARBINARY, SERIAL, TINYBLOB, ...

No issue with GEOMETRY, DATE, BOOLEAN, YEAR, ...

Server configuration

PHP version: 7.0.19-1
phpMyAdmin version: 4.7.7
Database: Server version: 10.2.10-MariaDB - Source distribution

Client configuration

Browser: 63.0.3239.108 (64 bits)

@williamdes williamdes mentioned this issue Dec 26, 2017
Closed
williamdes added a commit to williamdes/phpmyadmintest that referenced this issue Dec 26, 2017
Emptied the value when it is hidden.
Fixes the issue phpmyadmin#13889

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit to williamdes/phpmyadmintest that referenced this issue Jan 20, 2018
Fixes the issue phpmyadmin#13889

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit to williamdes/phpmyadmintest that referenced this issue Feb 12, 2018
Fixes the issue phpmyadmin#13889

Signed-off-by: William Desportes <williamdes@wdes.fr>
nijel added a commit that referenced this issue Feb 20, 2018
Fix charset error when creating/editing routines; bug #13889
@nijel nijel self-assigned this Feb 20, 2018
@nijel nijel added this to the 4.8.0 milestone Feb 20, 2018
@nijel
Copy link
Contributor

@nijel nijel commented Feb 20, 2018

Fixed by #13892.

@nijel nijel closed this Feb 20, 2018
@williamdes williamdes self-assigned this Feb 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants