New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open in new tab on edit query don't work on 4.7.7 #13890

Closed
r1si opened this Issue Dec 26, 2017 · 7 comments

Comments

Projects
None yet
7 participants
@r1si

r1si commented Dec 26, 2017

Steps to reproduce

  1. do an inline edit
  2. press click and press "Edit" under sql query edit box
  3. repeat the same with right button open in new tab

Expected behaviour

Open in new tab the query

Actual behaviour

With CTRL open in current windows, with mouse open in new tab with a generic select

Server configuration

Operating system:

Web server:

Database:

PHP version:
7.0
phpMyAdmin version:
4.7.7

Client configuration

Browser:
Chrome
Operating system:
w10

NOTE: with 4.7.6 all works fine !!

@nijel

This comment has been minimized.

Member

nijel commented Jan 8, 2018

Indeed it no longer works as we're no longer including SQL query in GET requests, but use POST instead to avoid leaking this information in the URL. So I'm sorry, but this will no longer work for privacy reasons.

@nijel nijel closed this Jan 8, 2018

@nijel nijel self-assigned this Jan 8, 2018

@nijel nijel added bug wontfix labels Jan 8, 2018

@r1si

This comment has been minimized.

r1si commented Jan 8, 2018

@nijel Can make another button to edit query in new tab ? with target blank form

@r1si r1si changed the title from open in new tab on edit query dont't work on 4.7.7 to open in new tab on edit query don't work on 4.7.7 Jan 29, 2018

@JFDionne

This comment has been minimized.

JFDionne commented Mar 11, 2018

Hi @nijel , I have the same issue, I was using alot the "edit on a new page", when we do a big search we don't to redo the search if I want to edit some rows.

Is there a way for make an option for the "edit button" open on a new page and don't discard the current?

@parsibox

This comment has been minimized.

parsibox commented Jun 14, 2018

i also need this

@mightydok

This comment has been minimized.

mightydok commented Jun 15, 2018

+1
Let save data to cookie like next step

@ekonoval

This comment has been minimized.

ekonoval commented Jun 20, 2018

Can somebody tell me which is the last version where this feature is supported?

@tswestendorp

This comment has been minimized.

tswestendorp commented Jun 21, 2018

@ekonoval that would be 4.7.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment