New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings reset prevents login and causes PHP Warnings #13914

Closed
svivian opened this Issue Jan 5, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@svivian

svivian commented Jan 5, 2018

Steps to reproduce

  1. Set up the meta tables (particularly, phpmyadmin.pma__userconfig).
  2. Go to "More Settings" from the home page, the Features.
  3. Click Reset, the Apply

Expected behaviour

Settings to be reset.

Actual behaviour

The "Login cookie validity" and "Maximum tables" fields go blank when clicking Reset. When clicking Apply this immediately causes PMA to log me out, and shows a warning:

Warning in ./libraries/plugins/auth/AuthenticationCookie.php#387
A non-numeric value encountered

Now when I try to log in it logs me straight back out again immediately (presumably because the login time is getting parsed as 0). Even updating or deleting the config manually from the pma__userconfig table doesn't work as it seems some settings are stored in cookies.

So the main fix would be for those two fields should be set to their default instead of blanks. Perhaps it would also be worth setting an absolute minimum so it cannot be set to 0 or 1 second?

PMA 4.7.7, PHP 7.1, MySQL 5.6.13, Apache 2.4.28.

@svivian

This comment has been minimized.

svivian commented Jan 5, 2018

This also happens with other settings, such as "Query history length" and "Maximum displayed SQL length" in the SQL queries section. Won't list them all as there seem to be many.
Edit: actually seems to be every text box (<input type="text">)

@nijel nijel self-assigned this Jan 8, 2018

@nijel nijel added the bug label Jan 8, 2018

@nijel nijel added this to the 4.7.8 milestone Jan 8, 2018

@nijel nijel closed this in 62ba273 Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment