New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove font size feature #13919

Closed
mauriciofauth opened this Issue Jan 8, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@mauriciofauth
Member

mauriciofauth commented Jan 8, 2018

screenshot from 2018-01-08 15-50-42

I think this feature does not make sense anymore, because the zooming feature of browsers is more efficient.

@shucon

This comment has been minimized.

Contributor

shucon commented Jan 11, 2018

I'm starting to work on this.

shucon added a commit to shucon/phpmyadmin that referenced this issue Jan 11, 2018

Remove font size feature
phpmyadmin#13919
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

@shucon shucon referenced this issue Jan 11, 2018

Merged

Remove font size feature #13925

4 of 4 tasks complete
@Interghost

This comment has been minimized.

Interghost commented Feb 20, 2018

Hi,

I'm probably among the not so many users of this great feature and would very much like it to stay.
On my QHD monitor the default 82% letters are too small and require exertion to read while most of the screen is actually blank as everything is small. Setting the font size to 92% is perfect in my case.

The browser zoom feature is definitely a step down as that feature does a "graphical" zoom of everything meaning the images are stretched as if taking an image and resizing it to a bigger resolution producing a very ugly blurry display.

EDIT: Attached an image with comparison, left is browser zoom 110%, right font size: 92% (note that the letters are not the point, they are fine, but the images)
compare

@shucon

This comment has been minimized.

Contributor

shucon commented Feb 21, 2018

The icons in the right image are smaller than the right one, so uploading higher res images would help.

@Interghost

This comment has been minimized.

Interghost commented Feb 21, 2018

Having higher res icons would mean you would downscale them by default (lets say 32x32 icon, in a 16x16 space) ... I think that would produce the above issue by default, depending how good a browser is in downscaling. Although it would look good/better when zoomed.

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Mar 15, 2018

@mauriciofauth mauriciofauth self-assigned this Apr 14, 2018

mauriciofauth added a commit that referenced this issue Apr 14, 2018

Add ChangeLog entry for #13919
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment