Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert page should prompt before reducing number of rows #13952

Closed
ibennetch opened this issue Jan 27, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@ibennetch
Copy link
Member

commented Jan 27, 2018

On the Insert page, when we add rows to the page with the "Continue insertion with __ rows" function, there is a risk of data loss if the user adds data to these rows then accidentally reduces the number of rows. When changing the number of rows, we should check if we're reducing the number, and if we are then we should check if there's been data input and prompt the users.

@mauriciofauth

This comment has been minimized.

Copy link
Member

commented Jan 27, 2018

This case already existed before #13876, but now it became more evident.

@shucon

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2018

@ibennetch I'm starting to work on this.

@shucon shucon referenced this issue Feb 10, 2018

Merged

Prompt before reducing number of rows #13987

3 of 4 tasks complete

mauriciofauth added a commit that referenced this issue Feb 14, 2018

Prompt before reducing number of rows (#13987)
Fixes #13952

* Prompt before reducing number of rows
* Edit Error Message
* Changed code location
* Fix minor bug
* Improve code quality
* Codacy Fix
* Minor Bug fix
* Travis Rerun
* Requested Changes
* Fix code quality

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

@mauriciofauth mauriciofauth self-assigned this Feb 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.