Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiling breaks user session #13969

Closed
mauriciofauth opened this issue Feb 6, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@mauriciofauth
Copy link
Member

commented Feb 6, 2018

Steps to reproduce

  1. Browse some table
  2. Click the Profiling checkbox

Expected behaviour

Do the profiling

Actual behaviour

Breaks the user session and the only way to resolve is to start a new session.

screenshot-profiling

PHP Fatal error:  Uncaught Error: Call to a member function getScripts() on null in phpmyadmin/libraries/common.inc.php:428
Stack trace:
#0 phpmyadmin/ajax.php(15): require_once()
#1 {main}
  thrown in phpmyadmin/libraries/common.inc.php on line 428
Notice in ./libraries/common.inc.php#428
 Undefined property: PhpMyAdmin\Header::$header
Backtrace
./index.php#26: require_once(./libraries/common.inc.php)

Server configuration

Demo server
29d92a1 from master branch

@mauriciofauth mauriciofauth added the bug label Feb 6, 2018

@nulll-pointer

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2018

I have made a few changes and now it works for me.
screenshot_20180207_163737

Should i make a PR.

@mauriciofauth

This comment has been minimized.

Copy link
Member Author

commented Feb 7, 2018

@nulll-pointer Absolutely!

@nulll-pointer

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2018

I have a pr pending on the master branch.
#13971

@mauriciofauth

This comment has been minimized.

Copy link
Member Author

commented Feb 9, 2018

@nulll-pointer Create a new branch for each pull request, this way each PR becomes independent. It's not recommended to commit directly to the master branch.

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Feb 9, 2018

Fix for issue phpmyadmin#13969
Changed file ./libraries/common.inc.php
Removed member header from line '$response->getHeader()->header->getScripts()', there is no such member.
Signed-Off-By: Lakshay arora (b16060@students.iitmandi.ac.in)

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Feb 9, 2018

Fix for issue phpmyadmin#13969
Changed file ./libraries/common.inc.php
Removed member header from line '$response->getHeader()->header->getScripts()', there is no such member.
Signed-Off-By: Lakshay arora (b16060@students.iitmandi.ac.in)

@mauriciofauth mauriciofauth self-assigned this Feb 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.