Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some icons with wrong size in the Original theme #14013

Closed
mauriciofauth opened this issue Feb 14, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@mauriciofauth
Copy link
Member

commented Feb 14, 2018

Steps to reproduce

  1. Open phpMyAdmin
  2. Select the Original theme

Expected behaviour

screenshot from 2018-02-14 18-37-09
screenshot from 2018-02-14 18-38-03

Actual behaviour

screenshot from 2018-02-14 18-39-00
screenshot from 2018-02-14 18-38-35

Server configuration

phpMyAdmin version: 4.8.0-dev, 095c3a8 from master branch

@shucon

This comment has been minimized.

Copy link
Contributor

commented Feb 14, 2018

@mauriciofauth why is themes/pmahomme/css/icons.inc.php being used by both the themes (Original and pmahomme) ? I found the bug, but this is quite confusing.

@ramantehlan

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2018

I have a solution. Already submitted a pull request.

@shucon

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2018

I don't think it's the right way to do it. And also the problem stated above should be resolved.

@ramantehlan

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2018

It do solve the problem.

@mauriciofauth mauriciofauth self-assigned this Feb 16, 2018

@mauriciofauth

This comment has been minimized.

Copy link
Member Author

commented Feb 16, 2018

@shucon It's not a problem. If a file does not exist on some theme, it fallback to the same file in the pmahomme theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.