Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parameter in 'AllowThirdPartyFraming' #14019

Closed
ttodua opened this issue Feb 16, 2018 · 0 comments
Closed

Allow parameter in 'AllowThirdPartyFraming' #14019

ttodua opened this issue Feb 16, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@ttodua
Copy link
Contributor

@ttodua ttodua commented Feb 16, 2018

$cfg['AllowThirdPartyFraming'] is set to TRUE/FALSE only. I think it's a kinda limitation, because we should be able to set the intermediate value 'SAMEORIGIN' (as mentioned here )

at this moment, PMA uses this code:

        if (! $GLOBALS['cfg']['AllowThirdPartyFraming']) {
            header(
                'X-Frame-Options: DENY'
            );
        }

so, you should allow to use also 'SAMEORIGIN' value

@nijel nijel added the enhancement label Feb 20, 2018
mauriciofauth added a commit that referenced this issue May 13, 2018
Issue #14019 fix: Allow parameter in AllowThirdPartyFraming
@mauriciofauth mauriciofauth self-assigned this May 13, 2018
@mauriciofauth mauriciofauth added this to the 5.0.0 milestone May 13, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants