New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error: Uncaught TypeError: Argument 5 passed to PhpMyAdmin\Table::_getSQLToCreateForeignKey() must be of the type array, string given #14030

Closed
Gemorroj opened this Issue Feb 20, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@Gemorroj
Contributor

Gemorroj commented Feb 20, 2018

Steps to reproduce

  1. Create 2 tables
  2. Create foreign key constraints
  3. Click "Preview SQL"
  4. Show server http response (php fatal error)

Server configuration

Operating system: Windows 7 x64
Database:: MySQL 5.7.x
PHP version:: 7.1.14
phpMyAdmin version:: 4.8.0-dev

sql

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Feb 20, 2018

Fixes error in foreign key sql genration, issue phpmyadmin#14030
Changed:
	templates/table/relation/foreign_key_row.twig
The destination_column_names were getting passed as a 1d array, the names when extracted gave a string. Passing it as a 2d array (see templates/table/relation/foreign_key_row.twig lines 123,133) fixes the issue.

Sign-Off-By: Lakshay arora (b16060@students.iitmandi.ac.in)

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Feb 24, 2018

Fixes error in foreign key sql generation + drop foreign key contrain…
…t, issue phpmyadmin#14030

Changed:
	templates/table/relation/foreign_key_row.twig
Signed-Off-By : Lakshay arora (b16060@students.iitmandi.ac.in)
@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Mar 25, 2018

Duplicate of #13941

@mauriciofauth mauriciofauth marked this as a duplicate of #13941 Mar 25, 2018

@mauriciofauth mauriciofauth self-assigned this Mar 25, 2018

mauriciofauth added a commit that referenced this issue Mar 27, 2018

Fixes error in foreign key sql generation + drop foreign key contraint (
#14031)

* Fixes error in foreign key sql genration, issue #14030
Changed:
	templates/table/relation/foreign_key_row.twig
The destination_column_names were getting passed as a 1d array, the names when extracted gave a string. Passing it as a 2d array (see templates/table/relation/foreign_key_row.twig lines 123,133) fixes the issue.

Sign-Off-By: Lakshay arora (b16060@students.iitmandi.ac.in)

* Fixes error in foreign key sql generation + drop foreign key contraint, issue #14030
Changed:
	templates/table/relation/foreign_key_row.twig

Fix #13941
Fix #14009
Close #14037
Close #14010

Signed-off-by: Lakshay arora <b16060@students.iitmandi.ac.in>

@mauriciofauth mauriciofauth referenced this issue Mar 27, 2018

Closed

Fix broken Relation View #14010

4 of 4 tasks complete

mauriciofauth added a commit that referenced this issue Mar 27, 2018

Fixes error in foreign key sql generation + drop foreign key contraint (
#14031)

* Fixes error in foreign key sql genration, issue #14030
Changed:
	templates/table/relation/foreign_key_row.twig
The destination_column_names were getting passed as a 1d array, the names when extracted gave a string. Passing it as a 2d array (see templates/table/relation/foreign_key_row.twig lines 123,133) fixes the issue.

Sign-Off-By: Lakshay arora (b16060@students.iitmandi.ac.in)

* Fixes error in foreign key sql generation + drop foreign key contraint, issue #14030
Changed:
	templates/table/relation/foreign_key_row.twig

Fix #13941
Fix #14009
Close #14037
Close #14010

Signed-off-by: Lakshay arora <b16060@students.iitmandi.ac.in>
(cherry picked from commit 00b5962)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment