Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing padding #14053

Closed
OlafvdSpek opened this issue Mar 4, 2018 · 12 comments · Fixed by #14730
Closed

Missing padding #14053

OlafvdSpek opened this issue Mar 4, 2018 · 12 comments · Fixed by #14730
Assignees
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted ui Issues relating to the user interface
Milestone

Comments

@OlafvdSpek
Copy link

pma

@akshilshah
Copy link

Hi, can you send the more details? like which system, browser, phpmyadmin version.

@OlafvdSpek
Copy link
Author

Chrome, pMA git

@williamdes
Copy link
Member

@OlafvdSpek Can you send more detailed information to reproduce ?

@OlafvdSpek
Copy link
Author

What info is missing?

@williamdes
Copy link
Member

@OlafvdSpek The query ?

@OlafvdSpek
Copy link
Author

I doubt it's query-specific.

@williamdes
Copy link
Member

@OlafvdSpek Can you please send a way to reproduce this issue ?
selection_092

@williamdes
Copy link
Member

williamdes commented Nov 15, 2018

This issue exists !
Run the following query:

use mysql;
SELECT `Host`, `User`, `Host` a, `Host` ddddddddddddddddddcddddddddddddddddddddddddb, `Host` cdddddddddddddddddcddddddddddddddddd, `Host` ddddddddddddddddddd, `Host` ddddddddddddddddddddde, `Host` ddddddddddddddddcddddddddddddddddddddddddddf, `Host` gzzzzzzzzzzzzcdddddddddddddddddzzzzzzzzzzzzzzzzzzz, `Host` gzzzzzzzdzzzzzcdddddddddddddddddzzzzzzzzzzzzzzzzzzz, `Host` gzzzzzzzzzzzzcdddddddddddddddddzzzzzzzszzzzzzzzzzzz, `Host` gzzzzzzzzfzzzzcdddddddddddddddddzzzzzzzezzzzzzzzzzzz, `Host` gzzzzzzzzzezzzcdddddddddddddddddzzzzzzzzzzzzzzzzzzz, `Host` gzzzzzzzzzzzzcdddddddddddddddddzzzzzzzzzzzzzfzzzzzz, `Host` gzzzzzzzzzzzzcdddddddddddddddddzzzzzzzzzzzzzzzzzzz, `Host` gzzzzzzzzzzzzcddddddfdddddddddddzzzzzzzzzzzzzzzzzzz, `Host` gzzzzzzzzzzzzcdddddddddddddddddzzzzzzzzzzzzfzzzzzzz,  `Host` gzzzzzzzzzzzzzzzzzzzzzzzzzzcdddddddddddddddddzzzzzzzzzzzzzzzzzzz,  `Host` gzzzzzzzzzzzzzzzzzzzzzzzzzzcdddddddddddddddddzzzzzzzzzzzzzzzzzzzz,  `Host` gzzzzzzzzzzazzzzzzzzzzzzzzcdddddddddddddddddzzzzzzzzzzzzzzzzzzz FROM `user` WHERE 1

This issue affects very long queries.

@williamdes williamdes added Bug A problem or regression with an existing feature help wanted ui Issues relating to the user interface good first issue labels Nov 15, 2018
@beekalam
Copy link
Contributor

@williamdes
In
import.php

there's

// (but if the query is too large, in case of an imported file, the parser
//  can choke on it so avoid parsing)
$sqlLength = mb_strlen($sql_query);
if ($sqlLength <= $GLOBALS['cfg']['MaxCharactersInDisplayedSQL']) {
   .........
}

if the query is bigger than 1000 characters long then it won't be parsed(or beautified).
is the issue about the query not being beautified or that it is not completely shown.
I am not sure what the issue is exactly?

@williamdes
Copy link
Member

@beekalam Thank you for the research, can you create a pull-request if you know how to fix this issue ?
The issue is not having the beautifier and the padding is missing.
PS: I updated the query to have a better test sample.

Screenshot

44667330-cec5-4e7b-ad54-0dd087aa5ab1

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Nov 18, 2018
MauricioFauth pushed a commit that referenced this issue Nov 28, 2018
Solves missed paddings on query results.

Fixes #14053 

Signed-off-by: Mohammad Reza Mansouri <beekalam@gmail.com>
@MauricioFauth MauricioFauth self-assigned this Nov 28, 2018
@MauricioFauth MauricioFauth added this to the 5.0.0 milestone Nov 28, 2018
MauricioFauth added a commit that referenced this issue Nov 28, 2018
[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@williamdes williamdes reopened this Jan 28, 2019
@williamdes
Copy link
Member

Still on 4.8.5

@williamdes williamdes self-assigned this Jan 28, 2019
@khaydarov
Copy link

khaydarov commented Feb 27, 2019

@williamdes
I wanted to start with this issue, but for me it is ok. Using 4.8.5

image

williamdes added a commit that referenced this issue Mar 16, 2019
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes modified the milestones: 5.0.0, 4.8.6 Mar 16, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted ui Issues relating to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants