Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS NULL search operator produces no WHERE SQL with spatial fields #14067

Closed
ChrisHSandN opened this Issue Mar 8, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@ChrisHSandN
Copy link

ChrisHSandN commented Mar 8, 2018

Steps to reproduce

CREATE TABLE `t` (
 `point` POINT DEFAULT NULL
) ENGINE=InnoDB;

INSERT INTO `t` (`point`) VALUES (NULL), (PointFromText('POINT(1 1)'));
  1. Go to Search tab on phpmyadmin
  2. Change point operator to "IS NULL" (or "IS NOT NULL")
  3. Click Go

Expected behaviour

Results should show 1 entry for the NULL point

Actual behaviour

No WHERE clause is added to SQL so whole table is returned

Server configuration

Operating system:
CentOS
Web server:
Apache/2.4.6
Database:
10.2.12-MariaDB
PHP version:
5.6.33
phpMyAdmin version:
4.7.7

@nulll-pointer

This comment has been minimized.

Copy link
Contributor

nulll-pointer commented Mar 20, 2018

isempty function works with null values.

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Mar 28, 2018

Fix for issues with spatial fields
Fixes the following issues:

1.    phpmyadmin#14068 SPATIAL fields with no unique index/autoincrement error when clicking
      This error occurs when there is no unique column to uniquely identify a tuple. I've disabled the geomtery view and made view as wkt the default view in such cases.

2.    phpmyadmin#14121 View spatial fields as WKT doesn't work

3.    phpmyadmin#14067 IS NULL search operator produces no WHERE SQL with spatial fields

@nulll-pointer nulll-pointer referenced this issue Mar 28, 2018

Merged

Fix for issues with spatial fields #14125

3 of 4 tasks complete

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Mar 28, 2018

Fix for issues with spatial fields
Fixes the following issues:

1.    phpmyadmin#14068 SPATIAL fields with no unique index/autoincrement error when clicking
      This error occurs when there is no unique column to uniquely identify a tuple. I've disabled the geomtery view and made view as wkt the default view in such cases.

2.    phpmyadmin#14121 View spatial fields as WKT doesn't work

1.    phpmyadmin#14067 IS NULL search operator produces no WHERE SQL with spatial fields

Signed-Off-By: Lakshya arora <arora.lakshya123@gmail.com>

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Apr 20, 2018

Fix for issues with spatial fields
Fixes the following issues:

1.    phpmyadmin#14068 SPATIAL fields with no unique index/autoincrement error when clicking
      This error occurs when there is no unique column to uniquely identify a tuple. I've disabled the geomtery view and made view as wkt the default view in such cases.

2.    phpmyadmin#14121 View spatial fields as WKT doesn't work

1.    phpmyadmin#14067 IS NULL search operator produces no WHERE SQL with spatial fields

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

mauriciofauth added a commit that referenced this issue May 12, 2018

Fix for issues with spatial fields (#14125)
*  Fix for issues with spatial fields

Fixes the following issues:

1.    #14068 SPATIAL fields with no unique index/autoincrement error when clicking
      This error occurs when there is no unique column to uniquely identify a tuple. I've disabled the geomtery view and made view as wkt the default view in such cases.

2.    #14121 View spatial fields as WKT doesn't work

1.    #14067 IS NULL search operator produces no WHERE SQL with spatial fields

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields
This commit fixes view as BINARY not working in the previous commit.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields

Fixes typo in previous commits.

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

@mauriciofauth mauriciofauth self-assigned this May 12, 2018

mauriciofauth added a commit that referenced this issue May 12, 2018

Fix for issues with spatial fields (#14125)
*  Fix for issues with spatial fields

Fixes the following issues:

1.    #14068 SPATIAL fields with no unique index/autoincrement error when clicking
      This error occurs when there is no unique column to uniquely identify a tuple. I've disabled the geomtery view and made view as wkt the default view in such cases.

2.    #14121 View spatial fields as WKT doesn't work

1.    #14067 IS NULL search operator produces no WHERE SQL with spatial fields

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields
This commit fixes view as BINARY not working in the previous commit.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields

Fixes typo in previous commits.

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
(cherry picked from commit 9231620)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

@mauriciofauth mauriciofauth added this to the 4.8.1 milestone May 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.