New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript error in Designer: getElementById() #14079

Closed
ibennetch opened this Issue Mar 13, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@ibennetch
Member

ibennetch commented Mar 13, 2018

In current master, when I am in Designer and click on the gear icon for a row (the gear icon at the top for each table works as expected).

Web Console has this error text:

TypeError: document.getElementById(...) is null
[Learn More]
move.js:1732:26
Click_option
http://192.168.56.2/pma-dev/fork/js/designer/move.js:1732:26
<anonymous>
http://192.168.56.2/pma-dev/fork/js/designer/move.js:2091:9
new_func
http://192.168.56.2/pma-dev/fork/js/error_report.js:248:28
dispatch
http://192.168.56.2/pma-dev/fork/js/vendor/jquery/jquery.min.js:2:41720
$event.dispatch
http://192.168.56.2/pma-dev/fork/js/vendor/jquery/jquery.event.drag-2.2.js:374:9
add/y.handle
http://192.168.56.2/pma-dev/fork/js/vendor/jquery/jquery.min.js:2:39774

aswaniprakash added a commit to aswaniprakash/phpmyadmin that referenced this issue Mar 19, 2018

JavaScript error in Designer: getElementById() phpmyadmin#14079 issue…
… fix

Signed-off-by: aswani <aswani15prakash@gmail.com>

aswaniprakash added a commit to aswaniprakash/phpmyadmin that referenced this issue Mar 19, 2018

JavaScript error in Designer: getElementById() phpmyadmin#14079 issue…
… fix

Signed-off-by: aswani <aswani15prakash@gmail.com>

aswaniprakash added a commit to aswaniprakash/phpmyadmin that referenced this issue Mar 27, 2018

File permission corrected phpmyadmin#14079
Signed-off-by: Aswani Prakash <aswani15prakash@gmail.com>

aswaniprakash added a commit to aswaniprakash/phpmyadmin that referenced this issue Mar 27, 2018

File permission changed phpmyadmin#14079
Signed-off-by: Aswani Prakash <aswani15prakash@gmail.com>

@mauriciofauth mauriciofauth added the bug label Mar 27, 2018

mauriciofauth added a commit that referenced this issue Mar 27, 2018

Fix case where 'query' is always considered defined
Related to #14079

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Mar 27, 2018

@ibennetch This button should not always be visible and I have already fixed this in commit ca7fd2b, but I don't know in what cases it should appear to test whether this issue has been fixed or not.

@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Mar 30, 2018

These buttons should only be visible when you are in Visual Builder mode.
For example, when you click on Switch to visual builder on QBE page: https://demo.phpmyadmin.net/master-config/db_qbe.php?server=1&db=sakila

So, apparently the commit ca7fd2b has fixed the bug, so I'll close this issue.

@mauriciofauth mauriciofauth self-assigned this Mar 30, 2018

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Mar 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment