New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designer: "Add options" dialog doesn't reset when canceling #14110

Closed
ibennetch opened this Issue Mar 21, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@ibennetch
Member

ibennetch commented Mar 21, 2018

This is with current master.

In Designer, (after fixing #14079, for instance with the pull request #14079), click the gear icon to the right of any column. Enter some text or change some dropdowns. Press cancel. Go to a different column and press the gear icon. The previous entries appear again.

I propose that it should come back with the default settings and not recall the previous entries.

@ibennetch ibennetch changed the title from Designer: "Add options" dialog doesn't reset when cancelling to Designer: "Add options" dialog doesn't reset when canceling Mar 21, 2018

@Piyush3079

This comment has been minimized.

Contributor

Piyush3079 commented Mar 22, 2018

For me it is giving Javascript error on clicking the gear icon.
Error in console:
TypeError: Cannot read property 'offsetWidth' of null
at Click_option (move.js?v=4.8.0-dev:1732)
at HTMLTableCellElement. (move.js?v=4.8.0-dev:2091)
at HTMLTableCellElement.new_func (error_report.js?v=4.8.0-dev:248)
at HTMLTableElement.dispatch (jquery.min.js?v=4.8.0-dev:2)
at HTMLTableElement.$event.dispatch (jquery.event.drag-2.2.js?v=4.8.0-dev:374)
at HTMLTableElement.y.handle (jquery.min.js?v=4.8.0-dev:2)

@vyeshwanth

This comment has been minimized.

Contributor

vyeshwanth commented Mar 23, 2018

@Piyush3079 Did u merge the pull request #14097 into the master branch of your fork?
Because #14097 fixes the error and then you will be able to see the "Add options" dialog.

Piyush3079 added a commit to Piyush3079/phpmyadmin that referenced this issue Mar 23, 2018

Designer: "Add options" dialog doesn't reset when canceling: phpmyadm…
…in#14110

 issue fix
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

Piyush3079 added a commit to Piyush3079/phpmyadmin that referenced this issue Mar 23, 2018

Designer: "Add options" dialog doesn't reset when canceling: phpmyadm…
…in#14110

 issue fix
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

Piyush3079 added a commit to Piyush3079/phpmyadmin that referenced this issue Mar 23, 2018

Revert "Designer: "Add options" dialog doesn't reset when canceling: p…
…hpmyadmin#14110"

This reverts commit b11ff54.
Signed-off-by: Piyush Vijay <piyushvijay.1997@mail.com>

Piyush3079 added a commit to Piyush3079/phpmyadmin that referenced this issue Mar 23, 2018

Designer: "Add options" dialog doesn't reset when canceling: phpmyadm…
…in#14110 issue fixed

Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

@mauriciofauth mauriciofauth self-assigned this Mar 30, 2018

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Mar 30, 2018

mauriciofauth added a commit that referenced this issue Mar 30, 2018

Designer: "Add options" dialog doesn't reset when canceling: #14110 i…
…ssue fixed (#14117)

* Designer: "Add options" dialog doesn't reset when canceling: Fix #14110
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* Designer: Add option dialogue error handling needs to be modified Fix #14126
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
(cherry picked from commit 6700b2d)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment